In view display menu tab colour is not visible completely when select any of item

Created on 7 February 2024, 5 months ago
Updated 19 April 2024, 2 months ago

Problem/Motivation

In the view display menu tab, the colour is not visible completely when selecting any of the items in the dropdown list.

Steps to reproduce

Go to view click on the add button select any item and see the add button color

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ› Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @shweta__sharma
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Anjali Mehta

    Anjali Mehta โ†’ made their first commit to this issueโ€™s fork.

  • First commit to issue fork.
  • Pipeline finished with Canceled
    4 months ago
    Total: 71s
    #95196
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Pravesh_Poonia

    Mentioned issue fixed and created MR

  • Status changed to Needs work 4 months ago
  • Tested MR !389 the issue gets resolved but another issue has been created by this. Changing the status to Needs work.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Rinku Jacob 13 Kerala

    hi @Pravesh_Poonia , i have checked the issue and applied your MR. like sweta said it was forming an another issue.in my local i have tried and got resolved the issue.
    my solution for this issue give important properties to views.scss file.

     .add a:hover,
      .add a:focus,
      li a:hover,
      li a:focus,
      li.is-active a,
      li.is-active a.is-active {
        color: var(--gin-bg-app) !important;
        background: var(--gin-color-primary);
        border-color: transparent;
      }
    .add {
        &.open {
          a {
            background: var(--gin-bg-layer2);
    
            &:hover, &:focus, &:active {
              color: var(--gin-color-primary) !important;
            }
          }
        }
      }
  • Looking at this issue too, it seems like the cause is a conflict with the Claro Theme css setting a colour in the `.add.open` class.

    Instead of using !important (which might cause other side effects), I would suggest the fix targets this class specifically, by setting the Gin theme colour at the same specificity.

    // _views.scss
    
      .add {
        &.open {
          a {
            background: var(--gin-bg-layer2);
            color: var(--gin-color-primary); // ADDED
    
            &:hover, &:focus, &:active {
              color: var(--gin-color-primary);
            }
          }
        }
      }
    
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

    ahsannazir โ†’ made their first commit to this issueโ€™s fork.

  • Pipeline finished with Success
    4 months ago
    Total: 227s
    #104662
  • Pipeline finished with Success
    4 months ago
    Total: 272s
    #104752
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

    Removed !important and added a style to target the class specifically.

  • Status changed to Needs review 4 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Kanchan Bhogade

    Hi
    I've tried to reproduce the issue but am unable to reproduce it, let me know if I am missing something.
    Tried on Drupal version 10.0 and 10.2
    followed below steps:

    1. Install Drupal version
    2. Install the Gin theme and set it as the default
    3. Add view and checking for the "Add" button color
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia divya.sejekan

    The issue looks fixed now. Add button remains same when selected any thing from dropdown.
    Another issue that was observed due to previous MR is also resolved

    Testing steps :
    1. Open view setting , click on ADD+ and select from dropdown
    2. Verify the ADD button after click

    Can be moved to RTBC++

    Keeping in Need review for further review

  • Status changed to RTBC 4 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Sanjeev P

    Reviewed the issue. It looks fixed.

  • Status changed to Fixed 3 months ago
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland saschaeggi Zurich

    Thanks for the fix!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024