- Issue created by @shweta__sharma
- ๐ฎ๐ณIndia Anjali Mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- First commit to issue fork.
- Merge request !389Fixed display menu tab colour visible issue. โ (Merged) created by Pravesh_Poonia
- Status changed to Needs work
9 months ago 7:47am 15 February 2024 Tested MR !389 the issue gets resolved but another issue has been created by this. Changing the status to Needs work.
- ๐ฎ๐ณIndia Rinku Jacob 13 Kerala
hi @Pravesh_Poonia , i have checked the issue and applied your MR. like sweta said it was forming an another issue.in my local i have tried and got resolved the issue.
my solution for this issue give important properties to views.scss file..add a:hover, .add a:focus, li a:hover, li a:focus, li.is-active a, li.is-active a.is-active { color: var(--gin-bg-app) !important; background: var(--gin-color-primary); border-color: transparent; }
.add { &.open { a { background: var(--gin-bg-layer2); &:hover, &:focus, &:active { color: var(--gin-color-primary) !important; } } } }
Looking at this issue too, it seems like the cause is a conflict with the Claro Theme css setting a colour in the `.add.open` class.
Instead of using !important (which might cause other side effects), I would suggest the fix targets this class specifically, by setting the Gin theme colour at the same specificity.
// _views.scss .add { &.open { a { background: var(--gin-bg-layer2); color: var(--gin-color-primary); // ADDED &:hover, &:focus, &:active { color: var(--gin-color-primary); } } } }
- ๐ฎ๐ณIndia ehsann_95
ahsannazir โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia ehsann_95
Removed !important and added a style to target the class specifically.
- Status changed to Needs review
9 months ago 9:58am 27 February 2024 - ๐ฎ๐ณIndia Kanchan Bhogade
Hi
I've tried to reproduce the issue but am unable to reproduce it, let me know if I am missing something.
Tried on Drupal version 10.0 and 10.2
followed below steps:- Install Drupal version
- Install the Gin theme and set it as the default
- Add view and checking for the "Add" button color
- ๐ฎ๐ณIndia divya.sejekan
The issue looks fixed now. Add button remains same when selected any thing from dropdown.
Another issue that was observed due to previous MR is also resolvedTesting steps :
1. Open view setting , click on ADD+ and select from dropdown
2. Verify the ADD button after clickCan be moved to RTBC++
Keeping in Need review for further review
- Status changed to RTBC
9 months ago 9:09am 6 March 2024 - Status changed to Fixed
8 months ago 8:31am 5 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.