- Issue created by @Berdir
- Status changed to Needs review
5 months ago 9:43am 30 March 2024 - Status changed to Needs work
5 months ago 4:09am 3 April 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
4 months ago 12:05pm 27 April 2024 - Status changed to RTBC
4 months ago 6:52am 28 April 2024 - 🇬🇧United Kingdom catch
This looks fine, Berdir suggested it meets the threshold for 'no tests needed' and I agree - it's a one-liner, doesn't add a new code branch, tests would require copying some of field_collection schema etc. and we wouldn't need any of that for 11.x so it'd be 'disposable' test coverage.
- 🇮🇳India Pravesh_Poonia
Agreed with Berdir's assessment that this fix meets the criteria for 'no tests needed.' Since it's a straightforward one-liner without introducing new code branches, additional tests would involve duplicating schema content unnecessarily. Given that this issue is specific to older versions and won't impact Drupal 11.x, test coverage is deemed unnecessary
- First commit to issue fork.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
I think this is worth test coverage. Schema is complex and an area we've working on so if we make changes to 11.x and backport them I'd like to be sure we don't break this. FWIW field group fixed the deprecated format usage a while back in 🐛 [Drupal 10.2] Deprecated sequence type schema definition Fixed - it just has not been released.
Added a test.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Test only fails as expected https://git.drupalcode.org/project/drupal/-/pipelines/160210
- Status changed to Fixed
4 months ago 11:38pm 29 April 2024 -
alexpott →
committed af5acaac on 10.3.x
Issue #3437109 by Berdir, alexpott: Undefined array key "type" in...
-
alexpott →
committed af5acaac on 10.3.x
Automatically closed - issue fixed for 2 weeks with no activity.