Help text is partially cut off on taxonomy term list when there are no visible local task tabs

Created on 7 February 2024, 9 months ago
Updated 19 April 2024, 7 months ago

Problem/Motivation

Currently, the help text is partially cut off on taxonomy term list when there are no visible local task tabs (which can be the case because of a user's permissions). There is no issue when there are local tasks. See the attached screenshot.

Steps to reproduce

View a vocabulary's term list as a user that does not have any edit rights on the taxonomy itself.

Proposed resolution

Add some bottom-margin

Remaining tasks

Commit

User interface changes

Before

After

API changes

None

Data model changes

None

🐛 Bug report
Status

Fixed

Component

User interface

Created by

🇧🇪Belgium chewi3

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @chewi3
  • First commit to issue fork.
  • Status changed to Needs review 9 months ago
  • 🇮🇳India Pravesh_Poonia

    Mentioned issue fixed and created MR

  • Pipeline finished with Failed
    9 months ago
    Total: 4866s
    #89841
  • Pipeline finished with Success
    9 months ago
    Total: 220s
    #89892
  • 🇧🇪Belgium chewi3

    The change is applied to horizontal_toolbar.scss, but this CSS is only used when you are specifically using the horizontal toolbar (which is a theme setting).

    For me this doesn't fix the issue, since I am using the standard toolbar. But I assume it would be sufficient to apply the same changes to toolbar.scss as well.

  • Status changed to Needs work 9 months ago
  • 🇮🇳India Kanchan Bhogade

    Hi
    Verified and tested on Drupal version 10.1 for the GIn theme
    Applied patch successfully...

    Testing Steps

    1. Install drupal version
    2. Install the GIn theme and set it as the default
    3. Check for the vocabulary term list by user content editor
      (Editor with "Access the taxonomy vocabulary overview page. Get an overview of all taxonomy vocabularies." permission)
    4. Apply patch and check for the same

    Test Result:
    Default toolbar (Verticle Toolbar): Issue not fixed
    Horizontal toolbar: issue fixed

    Attaching screenshot for reference

    Moving to "Need works"

  • Pipeline finished with Success
    9 months ago
    Total: 211s
    #92024
  • Status changed to Needs review 9 months ago
  • 🇮🇳India Pravesh_Poonia

    Updated MR, Issue fixed

  • Status changed to Needs work 9 months ago
  • 🇮🇳India Kanchan Bhogade

    Hi
    Verified and tested the updated MR on the Drupal version 10.1 for the Gin theme
    Applied patch successfully...

    Test Result:
    Default toolbar (Verticle Toolbar): Issue fixed
    but for the Horizontal toolbar: The issue is not fixed

    Attaching screenshot for reference

    Moving to "Needs work"

  • Assigned to rupeshghar
  • Issue was unassigned.
  • Status changed to Needs review 9 months ago
  • 🇮🇳India rupeshghar

    I've submitted a merge request for the issue mentioned earlier. Initially, the CSS code was only functioning with a vertical toolbar file. Please review the updated merge request, and I have attached a screenshot for your reference.

  • 🇮🇳India Kanchan Bhogade

    Hi
    Verified and tested the updated MR #11 on the Drupal version 10.1 for the Gin theme
    Applied patch successfully...

    Test Result:
    Default toolbar (Verticle Toolbar): Issue fixed
    Horizontal toolbar: Issue fixed

    Attaching screenshot for reference

    keeping it to "Needs review" for code review and more reviews

  • Status changed to Needs work 9 months ago
  • 🇮🇳India djsagar

    Updated tag, moving NW.

  • Status changed to Needs review 9 months ago
  • Hi
    Verified and tested on Drupal version 10.1 and 10.2 for the GIn theme.
    Not able to reproduce the issue.

    Testing Steps -

    Install drupal version
    Install the GIn theme and set it as the default
    Check for the vocabulary term list by user content editor
    (Editor with "Access the taxonomy vocabulary overview page. Get an overview of all taxonomy vocabularies." permission)
    Apply patch and check for the same

    Attaching screenshot for reference.
    Keeping it in Needs review for more reviews.

  • I have tested on Drupal 10 the issue is fixed now. We can move to RTBC now.

    Thanks

  • Status changed to RTBC 8 months ago
  • 🇮🇳India djsagar

    The issue has been thoroughly verified by another member of the Drupal community now moving to the RTBC.

  • First commit to issue fork.
  • Status changed to Fixed 7 months ago
  • 🇨🇭Switzerland saschaeggi Zurich

    Thanks y'all 👏

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024