ParamConverterManager lazy services are broken and should use a service locator

By adding logging to Container::get():

    $this->loading[$id] = TRUE;
    file_put_contents('/tmp/container.log', implode(' ', array_keys($this->loading)). "\n", FILE_APPEND);

    try {
      $service = $this->createService($definition, $id);
    }

we can see the chains of services that are created:

router_listener router router.no_access_checks route_enhancer.param_conversion
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.views_ui
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.views_ui entity_type.manager
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.views_ui entity_type.manager string_translation
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.views_ui entity_type.manager string_translation string_translator.custom_strings
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.views_ui entity_type.manager entity.last_installed_schema.repository
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.views_ui tempstore.shared
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.views_ui tempstore.shared keyvalue.expirable
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.views_ui router.admin_context
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.views_ui entity.repository
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.views_ui entity.repository context.repository
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.configentity_admin
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager paramconverter.entity
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager paramconverter.entity_revision
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.menu_link
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.menu_link plugin.manager.menu.link
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.menu_link plugin.manager.menu.link Drupal\Core\Menu\MenuTreeStorageInterface
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.paramconverter.menu_link plugin.manager.menu.link menu_link.static.overrides
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.node_preview
router_listener router router.no_access_checks route_enhancer.param_conversion paramconverter_manager drupal.proxy_original_service.node_preview tempstore.private

If we lazily instantiate paramconverter_manager's services properly then we remove all those services from every single page load.

Rebased to make sure everything passed with all the changes from the last month.

Unfortunately caused a large number of failures.

Resolve the issue with ParamConverterManager's lazy services by implementing a service locator approach. Currently, services tagged 'paramconverter' are declared as lazy but are instantiated early during ParamConverterManager construction, leading to performance issues. To address this, convert ParamConverterManager to utilize a service locator, ensuring paramconverter services are lazily loaded only when required by a route. Additionally, remove the lazy proxy services for paramconverter services to streamline the process and improve performance

It appears that #[AutowireLocator] does not support priority ordering. This means that the services are not sorted correctly when iterating through all of them and some fail. I traced through the compiler builder and in PriorityTaggedServiceTrait::findAndSortTaggedServices() the services are initially correctly sorted but when the final array is built the services are indexed by service name and the ordering is lost.

https://github.com/symfony/symfony/issues/42506 implies this did work at some point - at least when using !tagged_locator instead of autowiring maybe - but it doesn't appear to here.

In fact, PriorityTaggedServiceTrait::findAndSortTaggedServices() does sort services correctly, but then later on ServiceLocatorTagPass::map() calls ksort($services) which destroys the order.

Opened https://github.com/symfony/symfony/issues/57344 with a fix in https://github.com/symfony/symfony/pull/57345

Upstream bug is fixed in Symfony 7.0.9

https://github.com/symfony/symfony/pull/57581