#JavaScript

Just ran into this in https://git.drupalcode.org/issue/drupal-3482699/-/jobs/4841663, same failure as #15 which is actually a path through several TestBase classes finally landing in OffCanvasTestTrait::waitForOffCanvasArea.

It's hard to tell if the usleep swap would fix this particular case since you'd think it'd fail earlier when calling mouseOver or click on the $block (because find would return NULL?), but it definitely makes sense regardless.

I repeated the original job that failed 1 in 3 times and now it's not failing at all. https://git.drupalcode.org/issue/drupal-3317520/-/jobs/4820216

Not sure what to make of that, maybe we don't need the trait after all. But I think the waitForElementVisible makes sense.

mstrelan → changed the visibility of the branch 3317520-settings-tray-repeat to hidden.

Using WaitTerminateTestTrait seems to allow us to unskip ::testEditModeEnableDisable without splitting to a separate class - https://git.drupalcode.org/issue/drupal-3317520/-/jobs/4819919

But it failed once where I removed the usleep. Instead of usleep, why don't we just use waitForElementVisible? This seems to pass 100/100 times - https://git.drupalcode.org/issue/drupal-3317520/-/jobs/4819970. And once more for good measure https://git.drupalcode.org/issue/drupal-3317520/-/jobs/4819989.

Have created another MR with just these fixes and updated the issue summary.

I tried a few things, results below:

• Unskipping ::testEditModeEnableDisable and repeating the class 1000 times resulted in a fail approx 1 in 3 times (skipped after 38 tests) - https://git.drupalcode.org/issue/drupal-3317520/-/jobs/4819032
• Skipping ::testBlocks and ::testValidationMessages and repeating the class 100 times resulted in 0 fails - https://git.drupalcode.org/issue/drupal-3317520/-/jobs/4819193
• As above, but with usleep removed, 0 fails - https://git.drupalcode.org/issue/drupal-3317520/-/jobs/4819250
• Moving ::testEditModeEnableDisable to its own class and repeating the original class, 0 fails - https://git.drupalcode.org/issue/drupal-3317520/-/jobs/4819383
• As above, but repeating the new test class, 0 fails - https://git.drupalcode.org/issue/drupal-3317520/-/jobs/4819468

So it seems if we simply split ::testEditModeEnableDisable to its own class we can unskip it, but also appears we might be able to remove the usleep. I don't have an explanation for why that might be the case though, I wonder if there's something strange going on with switching themes and if WaitTerminateTestTrait would help.