[DrupalMedia] Formatting lost when attempting to edit media within a list item in CKEditor 5

Only @lauriii knows the complex depths of GHS 😅

Can you please provide:

1. sample content to reproduce this
2. FilterFormat + Editor config entity to reproduce this

Ideally, all of those would be reduced to the minimum to rule out interactions with anything else: so only list + Drupal media functionality in CKEditor 5.

I confirm this issue. Also, the issue can be reproduced by simply embedding a media entity in the middle of the list. CKeditor 5 will terminate the list before the media item, and start a new list after the media item.

Initial content

<ol>
    <li>
        Lorem
    </li>
    <li>
        ipsum
    </li>
    <li>
        dolor
    </li>
    <li>
        sit
    </li>
    <li>
        amet
    </li>
</ol>

Content after adding a media entity

<ol>
    <li>
        Lorem
    </li>
    <li>
        ipsum
    </li>
</ol>
<drupal-media data-entity-type="media" data-entity-uuid="5e6a990d-38a7-434d-a708-ecd281c62f79">&nbsp;</drupal-media>
<ol>
    <li>
        dolor
    </li>
    <li>
        sit
    </li>
    <li>
        amet
    </li>
</ol>

Filter config

langcode: en
status: true
dependencies:
  module:
    - editor
    - media
name: 'Basic HTML'
format: basic_html
weight: 0
filters:
  filter_html:
    id: filter_html
    provider: filter
    status: false
    weight: -10
    settings:
      allowed_html: ''
      filter_html_help: false
      filter_html_nofollow: false
  filter_align:
    id: filter_align
    provider: filter
    status: false
    weight: 7
    settings: {  }
  filter_caption:
    id: filter_caption
    provider: filter
    status: false
    weight: 8
    settings: {  }
  editor_file_reference:
    id: editor_file_reference
    provider: editor
    status: false
    weight: 11
    settings: {  }
  media_embed:
    id: media_embed
    provider: media
    status: true
    weight: 100
    settings:
      default_view_mode: default
      allowed_view_modes: {  }
      allowed_media_types:
        image: image
        remote_video: remote_video

Editor config

langcode: en
status: true
dependencies:
  config:
    - filter.format.basic_html
  module:
    - ckeditor5
format: basic_html
editor: ckeditor5
settings:
  toolbar:
    items:
      - bold
      - italic
      - underline
      - '|'
      - link
      - '|'
      - bulletedList
      - numberedList
      - '|'
      - blockQuote
      - drupalMedia
      - insertTable
      - '|'
      - '|'
      - '|'
      - code
      - sourceEditing
  plugins:
    ckeditor5_sourceEditing:
      allowed_tags: {  }
    ckeditor5_list:
      reversed: false
      startIndex: false
    media_media:
      allow_view_mode_override: false
image_upload:
  status: false
  scheme: public
  directory: inline-images
  max_size: ''
  max_dimensions:
    width: null
    height: null

This seemed to be related to https://github.com/ckeditor/ckeditor5/issues/11198.

Feature (engine): Added a new `Model#insertObject()` method for inserting elements defined as objects by model schema (see #11198).

Also, I'm guessing the parent element attributes were not being recognized, which was causing the list to be split. Inheriting all from $blockObject when registering the schema did the trick.

Moving to NW for the tests

This is @lauriii's realm — he knows the DrupalMedia plugin best.

Test added.

Thank you @nmangold! The changes look good. It looks like we should have updated the schema when CKEditor 5 introduced document lists in https://github.com/ckeditor/ckeditor5/issues/11197 but we missed the note.. The change is minimal because the actual inherited schema definitions are equivalent to what is there currently.

Here's a 11.x patch too which is needed to commit this.

RTBC++

Test coverage looks great too 👍

The last submitted patch, 11: 3381557-11.patch, failed testing. View results →

Random failure in QuickStartTest, unrelated.

Committed d59acaf and pushed to 11.x. Thanks!

Committing 10.1.x once the CI run has passed.

Committed 2f71a47 and pushed to 10.1.x. Thanks!

lauriii → closed merge request !4705

Automatically closed - issue fixed for 2 weeks with no activity.

Zooney → changed the visibility of the branch 3381557-formatting-lost-when to active.