🇺🇸United States @nmangold

@idiaz.roncero Thank you for working on this. I have been trying to solve the language alias issue since the start.

As you have discovered, the highlightjs code does not allow getting the aliased languages, and it is not a trivial change. Also, I would rather not maintain that list in the filter due to the maintainability problem.

Can you look at https://github.com/highlightjs/highlight.js/issues/3938, which is the upstream issue regarding this problem. The best solution might be a third-party plugin to bridge the gap, but that is currently beyond my knowledge of library.

Since this issue cannot be reproduced using a vanilla Drupal installation, it seems this is specific to your project. I am closing this issue. Feel free to add more details when those are available. Thanks.

Thank you.

nmangold → made their first commit to this issue’s fork.

nmangold → created an issue.

@shinkula, I tested the module against Drupal 10.2.4 specifically using the steps you outlined to reproduce. Also, I am using it on several sites, and I know it does work as expected.

So, I am trying to figure out what is the scenario that does not work correctly for you. Have you tested against a vanilla Drupal install?

Can you debug what is happening in the file at web/modules/contrib/highlightjs_input_filter/src/Plugin/Filter/HighlightJs.php? The libraries are attached dynamically. Also, view web/modules/contrib/highlightjs_input_filter/js/highlightjs_input_filter.js to see how the language and copy button scripts are registered with hljs.

Unfortunately, I will need more information about how to reproduce the problem you are experiencing.

Hi @shinkula, can you verify if changing the HTML code block to XML will add the JS/CSS?

Also, verify if it works for you with another language, such as PHP? Try placing only a PHP block of code in the page content.

I believe this is a duplicate of https://www.drupal.org/project/highlightjs_input_filter/issues/3401537 🐛 Non aliased languages fail to import and prevent Copy plugin from loading Needs review

HTML is a non-aliased language within the Highlight JS library. Use XML instead. I am working to come up with a better solution.

I appreciate your attempt in helping. However, it seems you do not understand the issue. Purging the cache in Cloudflare temporarily fixes the issue. If the issue were a wrong URL, or redirect setting, then purging the Cloudflare cache would not help.

It is intermittent. It is not all images, and it does not always happen. It is media entity images embedded into CKEditor 5.

The cache settings in the .htaccess are the default from Drupal. The browser and proxy cache setting (Cache-control header) setting is 1 year. Changing that value does not fix the problem.

This does not appear to be a direct issue in Drupal, because the images exist on the server, clearing the cache in Drupal does not help, but after purging the URI of the image in Cloudflare the image will appear normally. So, it is likely a Cloudflare setting that should be changed.

All other details from the original post are spot on.

I am also experiencing this exact same issue. So, I would be interested in any potential solutions.

I resolved the issue by ultimately passing an associative array to BubbleableMetadata->mergeAttachments(). So, the multiple drupalSettings attachments could be merged properly.

nmangold → made their first commit to this issue’s fork.

Great explanation, and thanks for your contributions.

nmangold → made their first commit to this issue’s fork.

Added a Drupal "site".

Changed the wording in the introduction.

I was able to reproduce this issue only when the blocks of the same language are non-consecutive. For example, PHP->PHP does not produce the issue, but PHP->PHP->JS->PHP does produce the issue.

The changes in the MR does fix the issue.

Patch #2 resolved this issue for me.

The language, css c plaintext, is not a valid language. Therefore, no Highlight.js language library exists that matches that language. You need to edit the source and remove the incorrect languages, leaving only the one language you want to be styled.

Incorrect languages that remain when switching the language is an issue with CKEditor 5. Not this module. This module only detects the languages, and applies the stylesheet from Highlight.js.

This appears to be a duplicate of https://www.drupal.org/project/quicktabs/issues/3355556 🐛 Not working on Drupal 10 Needs review .

I could not reproduce this issue either.

@Vivek, Loading the last clicked tab is expected behavior created by the feature request in https://www.drupal.org/project/quicktabs/issues/3035749 → . However, I understand your concern, and I think an option should exist to disable that feature as needed. Especially, when using Ajax to load only tab on page load that may be different than the default.

I have created a feature request with a patch at https://www.drupal.org/project/quicktabs/issues/3390978 ✨ Add an option to disable the Tab History feature Needs review .

nmangold → created an issue.

I could not reproduce the issue using a vanilla Drupal install with the Quick Tabs module and submodules enabled. Do you experience the same issue if you switch to the Olivero theme?

nmangold → made their first commit to this issue’s fork.

I cannot reproduce this issue.

You should be able to use the selectors .views_slideshow_controls_text_next a for the next button, and .views_slideshow_controls_text_prev a for the previous button.

Try the highlight.js Input Filter → module for similar functionality on D9+ with several additional features.

I experienced this issue also. The token used was [node:field_content_image:entity], which I assume worked at some point.

After reading https://www.drupal.org/docs/contributed-modules/metatag/frequently-asked... → , I realized the proper token is [node:field_content_image:entity:field_media_image:entity:url].

nmangold → created an issue.

Test added.

This seemed to be related to https://github.com/ckeditor/ckeditor5/issues/11198.

Feature (engine): Added a new `Model#insertObject()` method for inserting elements defined as objects by model schema (see #11198).

Also, I'm guessing the parent element attributes were not being recognized, which was causing the list to be split. Inheriting all from $blockObject when registering the schema did the trick.

I confirm this issue. Also, the issue can be reproduced by simply embedding a media entity in the middle of the list. CKeditor 5 will terminate the list before the media item, and start a new list after the media item.

Initial content

<ol>
    <li>
        Lorem
    </li>
    <li>
        ipsum
    </li>
    <li>
        dolor
    </li>
    <li>
        sit
    </li>
    <li>
        amet
    </li>
</ol>

Content after adding a media entity

<ol>
    <li>
        Lorem
    </li>
    <li>
        ipsum
    </li>
</ol>
<drupal-media data-entity-type="media" data-entity-uuid="5e6a990d-38a7-434d-a708-ecd281c62f79">&nbsp;</drupal-media>
<ol>
    <li>
        dolor
    </li>
    <li>
        sit
    </li>
    <li>
        amet
    </li>
</ol>

Filter config

langcode: en
status: true
dependencies:
  module:
    - editor
    - media
name: 'Basic HTML'
format: basic_html
weight: 0
filters:
  filter_html:
    id: filter_html
    provider: filter
    status: false
    weight: -10
    settings:
      allowed_html: ''
      filter_html_help: false
      filter_html_nofollow: false
  filter_align:
    id: filter_align
    provider: filter
    status: false
    weight: 7
    settings: {  }
  filter_caption:
    id: filter_caption
    provider: filter
    status: false
    weight: 8
    settings: {  }
  editor_file_reference:
    id: editor_file_reference
    provider: editor
    status: false
    weight: 11
    settings: {  }
  media_embed:
    id: media_embed
    provider: media
    status: true
    weight: 100
    settings:
      default_view_mode: default
      allowed_view_modes: {  }
      allowed_media_types:
        image: image
        remote_video: remote_video

Editor config

langcode: en
status: true
dependencies:
  config:
    - filter.format.basic_html
  module:
    - ckeditor5
format: basic_html
editor: ckeditor5
settings:
  toolbar:
    items:
      - bold
      - italic
      - underline
      - '|'
      - link
      - '|'
      - bulletedList
      - numberedList
      - '|'
      - blockQuote
      - drupalMedia
      - insertTable
      - '|'
      - '|'
      - '|'
      - code
      - sourceEditing
  plugins:
    ckeditor5_sourceEditing:
      allowed_tags: {  }
    ckeditor5_list:
      reversed: false
      startIndex: false
    media_media:
      allow_view_mode_override: false
image_upload:
  status: false
  scheme: public
  directory: inline-images
  max_size: ''
  max_dimensions:
    width: null
    height: null

I have added more features to this module, including a module settings form, route, menu item. Also, the module is dynamically loading assets to optimize page load times.

Is this enough changes to consider? If not, please give me an example of the minimum amount of code to consider being approved.

nmangold → created an issue.

nmangold → created an issue.

I ran into this error when upgrading a site to D10 while the Upgrade Status module was still present. I fixed the problem by using the --no-update option when updating Drupal, and to remove the drupal/upgrade_status package. Then, running the update.

composer require 'drupal/core-recommended:^10' 'drupal/core-composer-scaffold:^10' 'drupal/core-project-message:^10' 'drush/drush:^12' --update-with-dependencies --no-update
composer require 'drupal/core-dev:^10' --dev --update-with-dependencies --no-update

composer remove drupal/upgrade_status --no-update

composer update

composer require drupal/upgrade_status

I ran into an issue after upgrading from 2.x to 3.x on a project. The site was throwing an error similar to "Template xxx is not defined..." I finally figured out the project was still using the older 1.x API which was deprecated in 2.x, and removed in 3.x. Hopefully, this helps someone else.

More details can be found at https://www.drupal.org/docs/contributed-modules/components/registering-t... → , and https://www.drupal.org/docs/contributed-modules/components/registering-t... → .

I updated this branch from 2.x, and pushed. So, this branch has the change, and everything is clear.

@batigolix Your last commit fixed the issue. https://git.drupalcode.org/project/migrate_devel/-/commit/4bf1ecc56d1a07...

It looks like you did that at the same time I was creating this patch. I missed your comment.

I think this can be marked as fixed.

@jackfoust. I think the problem here is this feature branch is not updated, and does not contain the latest changes from the 8.x-2.x branch. Specifically, the core version requirement was changed to ^9.5 in https://git.drupalcode.org/project/migrate_devel/-/commit/725b66750e1e69....

Here is another patch that will apply cleanly to THIS branch, before it is updated.

If I had push access to the issue branch, I could have updated the branch myself.

The correct key was not removed in the last release.

Added a patch that removes the core: 8.x.

nmangold → made their first commit to this issue’s fork.

Fixed misspelling.

nmangold → made their first commit to this issue’s fork.

The patch applied cleanly for me using 1.0-alpha3, and resolved the deprecation warning.

nmangold → created an issue.

Fixed a misspelling.

This fix is not in the patch. The fix is in the merge request.

These changes have already been made in https://www.drupal.org/project/views_accordion/issues/3290414 📌 Automated Drupal 10 compatibility fixes Fixed .

These changes have already been made in https://www.drupal.org/project/views_accordion/issues/3290414 📌 Automated Drupal 10 compatibility fixes Fixed .