- Issue created by @Sandeep Sanwale
- Merge request !7493Issue #3440959: Close icon is ovrlapping the title text in modal in claro → (Closed) created by Sandeep Sanwale
- Status changed to Needs review
8 months ago 4:05am 15 April 2024 - 🇮🇳India Sandeep Sanwale
Added the css so that close icon does not overlap the title.
- Status changed to Needs work
8 months ago 12:58pm 15 April 2024 - 🇺🇸United States smustgrave
MR appears to have issues.
But not sure we want to add that css to the global body selector.
- Status changed to Needs review
8 months ago 4:30am 16 April 2024 - 🇮🇳India Sandeep Sanwale
The MR issue has been resolved . I have added the css in body selector because in the olivero theme also this css added in body selector.Please review .
- Status changed to RTBC
8 months ago 12:29pm 16 April 2024 Hello @Sandeep, I've successfully reproduced the issue you were talking about, and the patch provided by you also got applied successfully. After applying the patch the issue is resolved now and there is a breathing space between the section title and the close button. So moving it to RTBC++.
Attaching screenshots before and after applying the patch for reference!- 🇮🇳India gauravvvv Delhi, India
I have a question? Why're we using Claro as a frontend theme?
Claro is an admin theme. Do we support using Claro as frontend theme?
FYI: This is working fine with Olivero frontend theme. Hi, @Gauravvvv
As far as I know there is no hard and fast rules regarding the usage of theme. Its completely subjective. Though I've also seen Claro being used as admin theme predominantly, but one might choose to opt it for their frontend theme based on their needs. So I think it'll be better to address the issue and fix it, no matter if someone is using it as frontend theme or admin theme, we should fix the flaws in the respective theme!- Status changed to Needs work
8 months ago 8:02am 17 April 2024 - 🇫🇷France nod_ Lille
We have the same rule in olivero, What's missing here would be to remove the hyphen rules in other places it is used in claro like the pcss files: media-library, vertical-tabs, form--managed-file, details,
- Status changed to Needs review
8 months ago 9:17am 17 April 2024 - Status changed to Needs work
8 months ago 9:21am 17 April 2024 - Status changed to Needs review
8 months ago 9:31am 17 April 2024 - 🇫🇷France nod_ Lille
we can still remove the hyphens: auto from the managed file css, we just need to keep break-word since it's different from the default
- Assigned to meghasharma
- Issue was unassigned.
- Status changed to RTBC
8 months ago 2:04pm 17 April 2024 - 🇮🇳India meghasharma
Hello @here, Commit is successfully removing the hyphens: auto from css & .pcss.css files. Looks good to me., So moving it to RTBC++. Thanks!.
- Status changed to Fixed
8 months ago 3:24pm 17 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.
"body {hyphens: auto}" is in 10.3.x/11.x and git blame is pointing to this issue.
Can someone check if the commits were merged correctly?- 🇺🇸United States kevinb623
Echoing Lars' comment #21.
We have had feedback from our editors regarding hyphens appearing in editor textareas. This is causing confusion between legit hyphen usage and those inserted by the CSS.
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
I am here to second kevinb623, and also, why do we not want WYSIWYG anymore? Let's keep the WYG as close to the WYS as we can.