Follow-up from 🐛 RouteProvider::getRouteCollectionForRequest() can poison query string of next request RTBC .
PathProcessorFiles takes the filename out of the URL and puts it into a $request->query (so that the path looked up for routing is system/files instead of the whole path, but this means the caching in RouteProvider::getRouteCollectionForRequest() has to store and restore the query parameters, which in turn led to caching bugs.
Instead of this, we could store the filename in $request->attributes so it doesn't override information from the request, and in RouteProvider::getRouteCollectionForRequest() trigger a deprecation if the query string changes after incoming path processing has run.
Active
11.0 🔥
Last updated
🐛 Cannot use a / in route parameter Needs work is worth looking at too - would allow us to remove the PathProcessor altogether.
📌 Simplify private file routing Needs work would solve this and bring everything more into line with normal routing, so let's try to get that done first. If for some reason that approach isn't possible, can take another look here.