Text becomes hyphenated after upgrade to 10.3.0

Open on Drupal.org →

Created on 7 July 2024, 6 months ago

Updated 13 September 2024, 3 months ago

Problem/Motivation

Text becomes hyphenated after upgrade to 10.3.0

This issue seems to be related to Olivero as the default theme. I tested another theme where the text was not hyphenated. Tested on PHP 8.2 and PHP 8.3. Upgrading to 10.3.1 does not fix the problem.

I have no idea what is causing this or how to configure it.

Steps to reproduce

Example update: (10.2.7 => 10.3.0)
Lock file operations: 0 installs, 20 updates, 0 removals
- Upgrading drupal/core (10.2.7 => 10.3.0)
- Upgrading drupal/core-composer-scaffold (10.2.7 => 10.3.0)
- Upgrading drupal/core-project-message (10.2.7 => 10.3.0)
- Upgrading drupal/core-recommended (10.2.7 => 10.3.0)
- Upgrading masterminds/html5 (2.8.1 => 2.9.0)
- Upgrading mck89/peast (v1.15.4 => v1.16.2)
- Upgrading pear/archive_tar (1.4.14 => 1.5.0)
- Upgrading psr/http-factory (1.0.2 => 1.1.0)
- Upgrading symfony/deprecation-contracts (v3.4.0 => v3.5.0)
- Upgrading symfony/event-dispatcher-contracts (v3.4.2 => v3.5.0)
- Upgrading symfony/polyfill-ctype (v1.28.0 => v1.29.0)
- Upgrading symfony/polyfill-iconv (v1.28.0 => v1.29.0)
- Upgrading symfony/polyfill-intl-grapheme (v1.28.0 => v1.29.0)
- Upgrading symfony/polyfill-intl-idn (v1.28.0 => v1.29.0)
- Upgrading symfony/polyfill-intl-normalizer (v1.28.0 => v1.29.0)
- Upgrading symfony/polyfill-mbstring (v1.28.0 => v1.29.0)
- Upgrading symfony/polyfill-php83 (v1.28.0 => v1.29.0)
- Upgrading symfony/service-contracts (v3.4.2 => v3.5.0)
- Upgrading symfony/translation-contracts (v3.4.2 => v3.5.0)
- Upgrading twig/twig (v3.8.0 => v3.10.3)

--
My test system:
Drupal Version
10.3.1
Web Server
Apache
Database-Version
10.5.22-MariaDB
Database updates
Up to date
PHP
8.2.20
Default Theme
Olivero 10.3.1

Proposed resolution

Long words should appear in same line without splitting with hyphens.

Remaining tasks

Manual testing. Specifically check for regression, see #5
Before and after screenshots available from the issue summary

User interface changes

Before fix:

After fix:

Introduced terminology

None

API changes

None

Data model changes

None

Release notes snippet

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Last updated 3 days ago

Maintained by
🇺🇸United States @mherchel
🇺🇸United States @proeung
🇺🇸United States @jwitkowski79
🇷🇺Russia @kostyashupenko
🇺🇸United States @andy-blum

Created by

Live updates comments and jobs are added and updated live.

Needs manual testing
The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.

Needs screenshots
The change alters the user interface, so before and after screenshots should be added to document the UI change. Make sure to capture the relevant region only. Use a tool such as Aviary on Windows or Skitch on Mac OS X.

Incomplete comments

Sign in to follow issues

Merge Requests

!9486Text becomes hyphenated after upgrade to 10.3.0
Open
Unnamed author
updated 3 months ago
!9484Text becomes hyphenated after upgrade to 10.3.0
Open
🇮🇳India Avani.Bhut
updated 3 months ago
!9261Text becomes hyphenated after upgrade to 10.3.0
Closed
🇮🇳India Avani.Bhut
updated 3 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 6 months ago →
🇬🇧United Kingdom catch
Can you post a screenshot of the issue?
Comment 6 months ago →
SDKD
I have added two screenshots. One with hyphens and one with the original look.
Comment 6 months ago →
🇬🇧United Kingdom catch
That's because of 🐛 Article text can overflow page on mobile viewports Fixed
Comment 6 months ago →
🇬🇧United Kingdom catch
Looking at those screenshots, I think this is probably a valid report, wondering if we could add hyphenate-limit-chars so that only actually long words get broken.
Comment 4 months ago →
🇮🇳India Avani.Bhut India
avani.bhut → made their first commit to this issue’s fork.
Merge request !92613459760: Text becomes hyphenated after upgrade to 10.3.0 → (Closed) created by Avani.Bhut
Status changed to Needs review 4 months ago11:11am 20 August 2024
Comment 4 months ago →
🇮🇳India Avani.Bhut India
I removed hyphens: auto from the body tag to fix the issue. This property was added in the Olivero theme, which wasn't the default theme in previous core versions.
Assigned to Avani.Bhut
Status changed to Needs work 4 months ago11:32am 20 August 2024
Comment 4 months ago →
🇮🇳India Avani.Bhut India
Pipeline finished with Failed
4 months ago
Total: 3738s
#259149
Pipeline finished with Success
4 months ago
Total: 463s
#259210
Issue was unassigned.
Status changed to Needs review 4 months ago12:10pm 20 August 2024
Comment 4 months ago →
🇮🇳India Avani.Bhut India
Comment 4 months ago →
🇳🇿New Zealand quietone
@avani.bhut, thanks for making the MR. Did you try the suggestion fix from comment #6?

This also needs manual testing and screenshots.
Status changed to Needs work 4 months ago2:45pm 20 August 2024
Comment 4 months ago →
🇺🇸United States smustgrave
For #12
Comment 4 months ago →
🇮🇳India Avani.Bhut India
@quietone Yes, I’ve tried using the hyphenate-limit-chars property, but it is not fully supported across all browsers. For instance, Firefox and Safari do not support this property. Please refer to the screenshot/Link for more details.

https://developer.mozilla.org/en-US/docs/Web/CSS/hyphenate-limit-chars#b...
Status changed to Needs review 4 months ago1:57pm 29 August 2024
Comment 4 months ago →
🇮🇳India Avani.Bhut India
Status changed to Needs work 4 months ago2:37pm 29 August 2024
Comment 4 months ago →
🇺🇸United States smustgrave
Scanning issue summary but still appears to be missing screenshots

Also MR should be against 11.x
Pipeline finished with Failed
3 months ago
Total: 491s
#281806
Comment 3 months ago →
System Message
avani.bhut → closed merge request !9261
Pipeline finished with Success
3 months ago
Total: 470s
#281811
Merge request !9484Issue #3459760: Text becomes hyphenated → (Open) created by Avani.Bhut
Comment 3 months ago →
🇮🇳India Avani.Bhut India
@smustgrave Please see the attached screenshot displaying the before and after changes.
Pipeline finished with Failed
3 months ago
Total: 7331s
#281859
First commit to issue fork.
Comment 3 months ago →
🇮🇳India nayana_mvr
nayana_mvr → changed the visibility of the branch drupal-3459760-3459760-text-becomes-hyphenated to hidden.
Merge request !94863459760: Fix text becomes hyphenated issue. → (Open) created by Unnamed author
Pipeline finished with Failed
3 months ago
Total: 839s
#282094
Comment 3 months ago →
🇮🇳India nayana_mvr
nayana_mvr → changed the visibility of the branch 3459760-text-becomes-hyphenated-after-upgrade to hidden.
Comment 3 months ago →
🇮🇳India nayana_mvr
I have verified the changes in the MR!9261 and can confirm that it fixes the issue. Adding before and after screenshots from reviewer perspective. Keeping this 'Needs Work' itself as the pipeline has some build issues related to nightwatch tests.
I tried to create a new branch from 11.x and raised the MR with the same changes to check whether it fixes that issue but was getting the same errors in the pipeline, so I hid that branch. Please ignore them.
Would appreciate if someone can guide me to understand and fix nightwatch test failure issues. Thanks.
Comment 3 months ago →
🇮🇳India nayana_mvr
Please find the before and after screenshots.
Comment 3 months ago →
josephgut
Will this also resolve the issue in Olivero with hyphenated text in the Title? Photo enclosed. Thanks for the work done on this module!
Comment about 2 months ago →
tkim49
Hi, I'm having the same issue with Claro (admin theme) on 10.3.6. See attached screenshot. Can you please review and provide a possible solution for Claro as well? Thank you.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024