Read more Links field not rendered in Olivero

I'd still be curious to know why these links were omitted by design. Seems like a Drupal core theme should support basic Drupal site building functionality of a teaser with these links.

I agree @Chris Matthews, the "Read more" links are an integral part of Drupal site building.

🐛 The site slogan doesn't show with Olivero Needs work is another case, where an integral part of Drupal was left out. See also 📌 Olivero: Center align content (instead of left align) Needs work .

Moving this issue from the Olivero contrib project to Drupal core > Olivero theme component.

I have added before and after patch screenshot (without read more and with read more button)

Hi @Gauravvvv,
Verified your patch #12 on Drupal 9 and 10 it's working fine. The read more link is rendered now.
Added screenshots for reference, moving to RTBC.

The last submitted patch, 12: 3154517-12.patch, failed testing. View results →

Reroll the patch file.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Already created the MR.

Thanks for working on this

Tagging for issue summary as that appears to be incomplete, recommend using the standard issue template

Tagging for tests as feel a simple assertion could be added to an existing test.

This simply works and cannot be intentional design - at best it was just missed in design screenshots.

Lets get this usability issue resolved, please.

I agree, designs often miss to mockup a feature like Language Switcher et Read more links.

But the actual coding must go beyond mockups.

Yes, aside it is not only the Read more link that is missing here. The number of content "views" is also missing without this change. This is something I show to logged in users on my sites and that is really useful if the statistics module is enabled. I'm sure there are more use cases for the "links", but cannot remember it.

It's really a nightmare that this case is lingering 4 years around. It look me hours to understand why the read more is not shown and comments on other pages point to misconfiguration of teaser display mode and other stuff. Really annoying. Commit this minor line change now, please. Over 4 years is 4 years too much!

The issue was originally created in the Olivero issue queue but moved, so it's not clear now that the issue is about a specific theme, so adding Olivero in title.

I've removed these links from sites before because clicking on the title (or a clickable card) is a well understood pattern for getting to content and the links generally add noise for me.

However if a design decision was taken to do this in Olivero I don't think the figma is sufficient to explain that, there should be a 'why' somewhere to go with the pictures. I also would have no idea where to find this figma, or any way to verify that it's the final designs. So if this goes won't fix again I think it needs d.o. documentation before that happens.

Tagging for both product and subsystem maintainer review.

Also this is another example of node display elements being controllable only via twig templates and not in manage display, layout builder, or content type settings. If these were implemented as an extra field and exposed manage fields/layout builder there'd be no special cases template variable at all.

Still needs an issue summary update which should summarise the disagreement before it goes back to committers too.

I've removed these links from sites before because clicking on the title (or a clickable card) is a well understood pattern for getting to content and the links generally add noise for me.

Each website has its requirements and differences. Although “Read more” is phased out on most [Drupal] sites, here the links can be (and are) used for additional functions, like statistics, for those who have that requirement.

figma

Are we relying too much on Figma? Is Figma too limited?

Mockups

Mockups are mockups, they should never represent the source of truth, but rather they represent what was planned. During development, it’s when we implement features correctly, and sometimes update the mockups accordingly.

Links, Language switcher and Site slogan are all examples of components that need more love and probably implementation updates back to mockups.

Let’s make sure we implement features correctly.

Rewrote the issue summary using the issue summary template.

@catch: It need to possible to show the links. If you decide on your own to remove the read more (and other links), go into content rype > manage display > Teaser and Hide the field Links, please.

This can also be done with an install profile if needed, but do not disallow people to enable the links and waste their time trying to enable it and they do not show up - bringing them into support issues and debugging hours, please. There is functionality like language switcher, statistics and read more and maybe more features behind. This is not a design thing.

If Figma (whatever this is) requires this, you can configure it on your individual website. Nobody will stop you from configuring it this way to comply with your Figma rules. But others who need the links can enable them the common way. Please make this flexible as Drupal normally is.

Added a functional test that runs the same tests from the Node module that checks for the Read more link, but uses the Olivero theme instead of Stark.

Hello,
I have reproduced the issue on Drupal 11.
The MR is applied successfully.

Testing steps-
Verify the teaser display mode of the page content type has the Links field enabled to be displayed.
Create a few test pages.
Enable the archive view.
Visit the /archive page, and verify no "Read more" links are visible in the node teasers.

Test Result:
The read more link is rendered now.
Added screenshots for reference.