- ๐ท๐ธSerbia finnsky
I apologize.
I read the task description poorly.
As for MR
JavaScript looks acceptable to me.
+1 RTBC - ๐บ๐ธUnited States trackleft2 Tucson, AZ ๐บ๐ธ
Are you sure no javascript would be required to find and make visible all of the contextual links on the page when you click the "Preview editable areas" link in the contextual links menu?
- ๐ท๐ธSerbia finnsky
No, I mean we can search in the module history.
These links have already worked with the dropdown list. And there is already a script and styles for them.
The backend for this module has changed several times recently, so we should just re-apply it.
I think js is not needed here at all. Maybe only for optimisation. - ๐บ๐ธUnited States trackleft2 Tucson, AZ ๐บ๐ธ
Are you saying that I should move the Javascript into that new file for managing toolbar-dropdown?
- ๐ท๐ธSerbia finnsky
Hello! Thank you for work here.
Initially we managed that dropdown via common abstract script:
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/navig...And it worked before. We need to check git history here probably to avoid duplications in common things
This Dropdown should be universal(not related to contextual links) and reusable. - ๐บ๐ธUnited States trackleft2 Tucson, AZ ๐บ๐ธ
@plopesc I've made the
meetsContentEntityRoutesCondition
method public, and used it to determine whether to add the links. - First commit to issue fork.
Tried to wrap-up the remaining task on this.I am not sure whether i have covered all the stuff that was expected out of the remaining work.If not it would be great if someone can specifically point out the remaining stuff so that we are on the same page of what all needs to be added as a part of this issue.
- ๐ฌ๐งUnited Kingdom catch
Adding ๐ Klaro library seems way too large? Active as a related issue since this could further affect page weight.