- Issue created by @ckrina
- 🇳🇿New Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- 🇪🇸Spain ckrina Barcelona
We discussed with @lauriii how to integrate the Contextual editing button into the Top Bar and we came up with this solution that will help unblock the Top Bar and the Navigation from becoming stable: move this Edit button (to show contextual areas) into the more actions dropdown.
The primary action would actually be the button to go to Edit the node if you're on a node, which actually has the same label: "Edit". Which makes it really complicated to understand what is this Edit button."Edit" label is problematic
Another problem the UI has is that the same label: "Edit" is used both to show the contextual actions and if you're in a node (the Edit option to go into the node). And it makes it really complicated to understand what is this Edit button and differentiate the 2 of them. So a follow-up would be to change the label for this contextual edit button. If it becomes complicated to find the right copy for this label the discussion should be moved to a follow-up so it doesn't block the Navigation from becoming stable.
Change the controller
Another conversation to have in the future is the UI pattern/controller this should be: it should be a toggle since it's showing and hiding the contextual areas that can be edited (I think for accessibility purposes). But please keep any change to this controller for a followup or we won't get this Stable blocker done.
As a final point, to keep in mind that this (almost not used) feature will progressively disappear with the new functionalities XB will provide.
- 🇧🇷Brazil joaopauloc.dev
joaopauloc.dev → made their first commit to this issue’s fork.
- Merge request !9992Adding preview editable areas local tasks into the navigation module. → (Open) created by joaopauloc.dev
- 🇧🇷Brazil joaopauloc.dev
Hi folks, follow the image below of the preview editable areas.
- 🇺🇸United States smustgrave
Even though this is categorized as a task think there is enough changes here to maybe warrant a simple test case. Least maybe an additional assertion in the module.
Thanks! Looks good I had nothing to add