Integrate Navigation with Contextual editing

Created on 1 August 2024, 3 months ago

Problem/Motivation

Navigation module does not have a capability to integrate the contextual link Edit.

Steps to reproduce

Proposed resolution

It needs to be added to the Top Bar because it's an action contextual to the content itself.

Remaining tasks

This needs designs. Please don't jump into implementation until there are designs.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

๐Ÿ“Œ Task
Status

Active

Version

11.0 ๐Ÿ”ฅ

Component
Navigationย  โ†’

Last updated about 2 hours ago

No maintainer
Created by

๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ckrina
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    I forgot to add the Navigation stable blocker tag.

  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona
  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone

    Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

  • ๐Ÿ‡ซ๐Ÿ‡ฎFinland lauriii Finland
  • ๐Ÿ‡ช๐Ÿ‡ธSpain ckrina Barcelona

    We discussed with @lauriii how to integrate the Contextual editing button into the Top Bar and we came up with this solution that will help unblock the Top Bar and the Navigation from becoming stable: move this Edit button (to show contextual areas) into the more actions dropdown.
    The primary action would actually be the button to go to Edit the node if you're on a node, which actually has the same label: "Edit". Which makes it really complicated to understand what is this Edit button.

    "Edit" label is problematic

    Another problem the UI has is that the same label: "Edit" is used both to show the contextual actions and if you're in a node (the Edit option to go into the node). And it makes it really complicated to understand what is this Edit button and differentiate the 2 of them. So a follow-up would be to change the label for this contextual edit button. If it becomes complicated to find the right copy for this label the discussion should be moved to a follow-up so it doesn't block the Navigation from becoming stable.

    Change the controller

    Another conversation to have in the future is the UI pattern/controller this should be: it should be a toggle since it's showing and hiding the contextual areas that can be edited (I think for accessibility purposes). But please keep any change to this controller for a followup or we won't get this Stable blocker done.

    As a final point, to keep in mind that this (almost not used) feature will progressively disappear with the new functionalities XB will provide.

  • ๐Ÿ‡ง๐Ÿ‡ทBrazil joaopauloc.dev

    joaopauloc.dev โ†’ made their first commit to this issueโ€™s fork.

  • Pipeline finished with Failed
    about 14 hours ago
    Total: 136s
    #324064
  • Pipeline finished with Success
    about 13 hours ago
    Total: 693s
    #324072
  • ๐Ÿ‡ง๐Ÿ‡ทBrazil joaopauloc.dev

    Hi folks, follow the image below of the preview editable areas.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Even though this is categorized as a task think there is enough changes here to maybe warrant a simple test case. Least maybe an additional assertion in the module.

    Thanks! Looks good I had nothing to add

  • Pipeline finished with Success
    about 4 hours ago
    Total: 1691s
    #324522
  • ๐Ÿ‡ท๐Ÿ‡ธSerbia finnsky

    Thank for commit.
    I added few notes about js.

Production build 0.71.5 2024