The icon for the more actions button is not visible

Debugged this with @plopesc and this looks like a regression in Chrome in version 133. 😭

How does one reproduce this?

We need to pause icons tickets and concentrate on Icon API implementation

https://www.drupal.org/project/drupal/issues/3483209 📌 Navigation leverage icon core API Needs work

It is not small hot fix but reason is in wrong icons management in module.

https://gyazo.com/cfbb9da933c5d883bf840b02a9b6a522

All buttons with only one icon broken. Close on mobile as well.
I would like to fix that system problem in global linked ticket.

I found that the issue appears to be Chrome's inability to interpret content: attr(data-icon-text); when the data-icon-text attribute is not set. We don't have any text label for this particular button, so I'm proposing that we add a new modifier, icon-only to the toolbar-button component, so we can style it explicitly as content: ''. That will make the ::before pseudo element appear as expected and fix the issue reported here.

This is a quick fix that we should be able to get in quickly before the icon management lands.

Updated issue summary. Marking as active. Will work on an MR.

1. I prefer not to duplicate class functionality. We already have [class*="toolbar-button--icon"]
We should use it. Just add a check for the text attribute.

2. In #6 I pointed out that the close button on mobile is also broken.

1. I prefer not to duplicate class functionality. We already have [class*="toolbar-button--icon"]
We should use it. Just add a check for the text attribute.

Good point! I've got rid of the extra modifier and class, and instead used a [class*="toolbar-button--icon"]:not([data-icon-text])::before selector. Is that what you meant, or did you have something else in mind?

2. In #6 I pointed out that the close button on mobile is also broken.

Sorry I missed this. I didn't know what you meant, b/c I couldn't see the icon, because it was broken 😆. The above selector catches the Close icon and fixes it as well.

Verified the problem following the steps provided in the IS.

Applying the MR did fix the issue, not uploading a screenshot as they are already included.

Javascript failure was random

Fixed in related issue.
https://www.drupal.org/project/drupal/issues/3483209 📌 Navigation leverage icon core API Needs work