- 🇮🇳India gauravvvv Delhi, India
Re-rolled #26, for Drupal 10. As es6 files are no longer used in D10. Also
popperjs
has been updated toloadjs
. Attached a patch and interdiff for same. Please review. - Status changed to Needs review
almost 2 years ago 6:24am 23 January 2023 - Assigned to Guru2023
- Status changed to Needs work
almost 2 years ago 1:05pm 23 January 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
-
+++ b/core/themes/claro/claro.libraries.yml @@ -202,6 +202,11 @@ autocomplete: + - core/loadjs
I don't believe loadjs is needed anywhere in this fix so this doesn't need to be added as a dependency
-
+++ b/core/themes/claro/js/shortcut.js @@ -0,0 +1,39 @@ +/** + * DO NOT EDIT THIS FILE. + * See the following change record for more information, + * https://www.drupal.org/node/2815083 + * @preserve + **/
In other words, use code from shortcut.es6.js from the earlier Drupal 9 patch in this shortcut.js file. This is a copy of the transpiled JS, and Drupal 10 no longer transpiles its JS (hence no .es6.js + .js files)
-
- Status changed to Needs review
almost 2 years ago 4:48pm 23 January 2023 - 🇮🇳India ankithashetty Karnataka, India
Made changes as pointed out in #38, thanks!
- Status changed to Needs work
almost 2 years ago 11:57pm 30 January 2023 The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 9:57am 1 February 2023 - Status changed to Needs work
almost 2 years ago 11:03am 1 February 2023 - 🇮🇳India ranjith_kumar_k_u Kerala
The PopperJS library has been removed from the core 10.0.0
core/popperjs asset library is deprecated →