Better shortcut action link styles when there's limited horizontal space

Created on 18 July 2019, over 5 years ago
Updated 12 April 2023, over 1 year ago

Problem/Motivation

When there's a limited amount of horizontal space, the shortcut action link will move to the next line. This looks awkward especially when only the star icon is visible.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Needs work

Version

10.1

Component
Claro 

Last updated 1 day ago

Created by

🇫🇮Finland lauriii Finland

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India gauravvvv Delhi, India

    Re-rolled #26, for Drupal 10. As es6 files are no longer used in D10. Also popperjs has been updated to loadjs. Attached a patch and interdiff for same. Please review.

  • Status changed to Needs review almost 2 years ago
  • Assigned to Guru2023
  • 🇮🇳India Guru2023

    I will double check this issue

  • Status changed to Needs work almost 2 years ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI
    1. +++ b/core/themes/claro/claro.libraries.yml
      @@ -202,6 +202,11 @@ autocomplete:
      +    - core/loadjs
      

      I don't believe loadjs is needed anywhere in this fix so this doesn't need to be added as a dependency

    2. +++ b/core/themes/claro/js/shortcut.js
      @@ -0,0 +1,39 @@
      +/**
      + * DO NOT EDIT THIS FILE.
      + * See the following change record for more information,
      + * https://www.drupal.org/node/2815083
      + * @preserve
      + **/
      

      In other words, use code from shortcut.es6.js from the earlier Drupal 9 patch in this shortcut.js file. This is a copy of the transpiled JS, and Drupal 10 no longer transpiles its JS (hence no .es6.js + .js files)

  • Status changed to Needs review almost 2 years ago
  • 🇮🇳India ankithashetty Karnataka, India

    Made changes as pointed out in #38, thanks!

  • Status changed to Needs work almost 2 years ago
  • The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

  • Issue was unassigned.
  • Status changed to RTBC almost 2 years ago
  • Status changed to Needs work almost 2 years ago
  • 🇧🇪Belgium borisson_ Mechelen, 🇧🇪

    There are issues found in #40 that have not been resolved in the meantime, is there a reason why you'd just ignore that update @Guru2023?

  • 🇮🇳India ranjith_kumar_k_u Kerala

    The PopperJS library has been removed from the core 10.0.0
    core/popperjs asset library is deprecated

Production build 0.71.5 2024