- Issue created by @nicoloye
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - @nicoloye opened merge request.
- last update
about 1 year ago Build Successful - Status changed to Needs review
about 1 year ago 8:41am 10 August 2023 - 🇫🇷France nicoloye
Here is a suggestion to handle this, c&c are welcome. Thanks!
- last update
about 1 year ago Build Successful - Status changed to Needs work
about 1 year ago 8:58am 10 August 2023 - 🇫🇷France Grimreaper France 🇫🇷
Hi,
After applying the fix proposed in https://git.drupalcode.org/project/drupal/-/merge_requests/4576#note_198895, here is the result with ui_suite_bootstrap.
And here is the result with Olivero.
So I wonder if something needs to be done to handle background color?
- last update
about 1 year ago 29,958 pass - Status changed to Needs review
about 1 year ago 9:11am 10 August 2023 - last update
about 1 year ago 29,958 pass - 🇩🇪Germany marcoliver Neuss, NRW, Germany
I agree with #5 ✨ Preview theme logo and favicon Needs work , something should probably be done in case we have a logo with a lot of white and transparency, as we with the one included in Olivero.
Maybe have two preview boxes for each image (with a light border), one with a white background, one with a black / dark grey background?
- Status changed to Needs work
about 1 year ago 9:32am 10 August 2023 - 🇫🇷France nicoloye
I agree with the background issue. I'm just not sure how to adress it. Should we leave a css is on the wrapper div and place the styles somewhere in the core itself (where?) or directly put a style attribute (which seems a bit dirty no?).
- 🇷🇺Russia kostyashupenko Omsk
I think the only goal for core system module is to display logo + favicon. The rest for for themes (background, colours, etc).
But not sure if it should be separate issue for theming - 🇷🇺Russia kostyashupenko Omsk
For uploaded logotypes / favicons would be (maybe) nice to have `cross` icon above the image to be able to quickly remove it. Pretty obvious behavior to me