Canberra
Account created on 9 October 2005, over 18 years ago
#

Merge Requests

More

Recent comments

πŸ‡¦πŸ‡ΊAustralia sime Canberra

This is just for editing the tree @nterbogt i think it won't effect that rendering.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

sime β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

I've moved to local patches so please use the diff from the MR if you need this.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Sorry for the patch spam. We're about to change processes to local patches, but in the meantime it looks like Prettier mangled the previous one.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

There are some great workarounds here, but I believe this is a duplicate of https://www.drupal.org/project/drupal/issues/3401726 πŸ› MediaLibraryUiBuilder service does not properly allow additional contextual filter arguments Needs work where there is a patch that solves the problem in the original issue for me - it will allow you to add a contextual filter to the media_library widget displays which uses the current logged in user as the media author.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Patch worked for me, and I've created the issue fork for it.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

sime β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Physical patch for the extant composer workflows.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

@pameeela except I've found the core one to be the best for bulk upload.

I'm going to solve this as a permissions thing, but in the meantime I have added a "Media created in the last 2 hours" filter to the media library views displays so that at least it's not the whole library they see.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Manual patch for the record

πŸ‡¦πŸ‡ΊAustralia sime Canberra

The attached code is working really well for us, and I would like to see this added to the entity_diff_ui as a submodule.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Physical patch

πŸ‡¦πŸ‡ΊAustralia sime Canberra

sime β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

sime β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

It took me a while to find that calling setErrorByName() was the way to set an error not by name. At least the parameter documentation should describe this.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Just leaving a note here that this custom code is throwing phpstan errors and I notice there are quite a lot in entity_diff_ui.

 ------ ----------------------------------------------------------------------------------------------
  Line   contrib/entity_diff_ui/src/Form/RevisionOverviewForm.php
 ------ ----------------------------------------------------------------------------------------------
  208    Call to deprecated method loadRevision() of class Drupal\Core\Entity\EntityStorageInterface:
         in drupal:10.1.0 and is removed from drupal:11.0.0. Use
         \Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead.
  211    Call to deprecated method loadRevision() of class Drupal\Core\Entity\EntityStorageInterface:
         in drupal:10.1.0 and is removed from drupal:11.0.0. Use
         \Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead.
πŸ‡¦πŸ‡ΊAustralia sime Canberra

The `revision_created` field is never updated.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

This works great for me. For the googlers - be warned that twig debug being switched on makes it look like its not working.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

I was wondering why my user action was not appearing when it there was clearly a base user table in my view through a relationship. Now I have an action that must have no "type" in order to be available to add to bulk operations, and the action itself must go through hoops to work out how to get to the entity IDs it wants to operate on.

I'd like to call this a serious bug.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

I was incorrect about it - the buildPreConfigurationForm stuff relates to an administrator configuring the operation, and not to the confirm step. I've looked at ConfirmAction.php in VBO and there is nothing that allows extending the form built into the action class. You'd have to extend and override the confirm form class or a form alter.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

The benefit of this is that given a from and to state, we can determine the transition ID.

This is a benefit but not critical - we can already order transitions, so determining the appropraite transition is a case of:

  1. What transitions are valid for these from/to states
  2. What transitions does the user have permission to use
  3. Which transition has the highest priority.
πŸ‡¦πŸ‡ΊAustralia sime Canberra

I am currently using Workflow Buttons β†’ module which takes a transition name and exposes it as a button. This has been working exceptionally well to give the user a much better sense of what they are trying to achieve rather than what the end moderation state will be.

For example a user sees a button [Save Progress] (the name of the transition) and this might push content from Published to Incomplete.

With this in place I can also add triggers when certain transitions are used. This means that when [Save Progress] is triggered I can send an email to that says "Hey well done for saving progress, but you'll need to come back later and finish the job".

So, now I want to add a transition [Request Review] and the permissions are set such that only Managers can execute this. This transition can also move content from Published to Incomplete. This means that I can send an different email when this transition is executed, as it has a different intention that than the transition that normal users can use.

There are a couple of considerations...

  • Workflow Buttons module is simply looking at the options on the form by default and finding the best transition. Maybe it could do it a different way and load the transitions that are applicable. This then makes the problem one that can be solved in Workflow Buttons.
  • If I was to use the ECA module it works by detecting the FROM->TO state and doesn't offer an ability to detect the transition used.

In the end, I just don't know why you can't have transitions that cover the same FROM->TO. It doesn't make any sense why this is enforced, and if it wasn't enforce it would allow more creative ways for contrib module to leverage the "transition as a verb" idea that was lost when core replaced buttons with a state drop-down.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Just adding a physical patch as well for my client's clarity.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

I've updated the 3x version with this code that works for synced roles

This issue πŸ’¬ Group::getMembers() returns empty for syncronized roles Fixed is where Webform Group module discussed the problem, but there wasn't any indication that this is a Group module bug or feature gap.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

This code doesn't work for me, as it doesn't work where roles are sync'd or inherited from global roles, only when group roles are manually assigned.

BTW I've updated this code to be compatible with 3.x of workbench_email and 3.x of Group module. I pushed this code to a different branch 3302006-integrate-with-group-3x in the issue fork for the record.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

sime β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Specifically this comment β†’ refers to a future roadmap of multiple drafts.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Oh wonderful, thanks I never found that one.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

> when Content Moderation was made stable in core, it did not have the capability to do this. I'm not sure if it does now; I'd hope so. It bears further research for sure.

Still the case unfortunately.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Thanks so much

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Sorry i forgot to close it. I was able to use the switch user action.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Inline Entity Form 2.x is has been deprecated as a bad release.
https://www.drupal.org/project/inline_entity_form/issues/3401656 πŸ“Œ Clean up problematic 2.x branch Active

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Yeah the comparison to Media access checking is a good one - patch works for me.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

https://www.drupal.org/project/drupal/issues/3292350#comment-15324953 πŸ› file_validate_image_resolution does not update file size after resizing Needs work worked for me.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Just for #18 and #19 I've attached code for Diff UI support on πŸ“Œ Code for Profile Diff UI Closed: won't fix .

πŸ‡¦πŸ‡ΊAustralia sime Canberra

sime β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

sime β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

If a module overrides field.html.twig, it might not be adding the clearfix class. This happened to me with field_label module.
https://www.drupal.org/project/field_label/issues/3408637 πŸ› Clearfix missing Active

πŸ‡¦πŸ‡ΊAustralia sime Canberra
πŸ‡¦πŸ‡ΊAustralia sime Canberra

sime β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

We noticed multiple issues when editing embedded entities using complex widget, these went away on 1.x branch. If you are on GovCMS PaaS but using the distribution you can do this for now but note that we are in pre-production so we have plenty of space to manage the risk of going back.

        "drupal/inline_entity_form": "1.x-dev as 2.0.0-rc9",
πŸ‡¦πŸ‡ΊAustralia sime Canberra

That is really good to know. I'll leave this open for when i have a chance to dive deeper.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

I would recommend takings pieces from the view until it works.

For example I had one view where the Contextual Filter had been inherited from the default display, where it wasn't needed, and removing this allowed the export to work again. I assume that the missing context caused Views to throw the 404 (which is what the Watchdog said happened) while the browser was left none the wiser.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

sime β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

GroupRelationshipForm::save also involved.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

I'm started to doubt myself that this is a good thing to mess and it should be done at the form or entity form level.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

lauriii/berdir/alexpott have outstanding concerns. Maybe it's pedantic but i want to address some concerns again.

It should work like LinkItem - structurally the setting is working like LinkItem, being a setting with enumerated options. But I think the comparison should stop there. IMO there is subtle difference between LinkItem "make the label optional" and DataRangeItem "make half of the data structure optional".

We made it more complex by considering future optional start date - agreed, but it helps to split the language up because you can describe each radio option separately, and the side effect is that it will save a future update hook if we add optional start date. If core devs want a boolean option, then I will re-roll the patch because I was the one who turned the checkbox into radios.

we shouldn't use "OPTIONAL_" language in the code - I don't think this should be a deal breaker. when i was looking at the code, i foudn that mentally differentiating between "required" (field) and "required" (part of a field) is mental gymnastics. So using the language "part of this required field is optional in this situation" I think is a solid step, and also matches how we describe it in the issue title.

The form labels are confusing - totally valid. rkoller and I considered different options and think it's pretty close. If we can settle on the underlying data model/code then we can finalise the labels?

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Yes, per #59 if you do this code below then the current implementation of MenuLinkAdd will clobber this.

/**
 * Implements hook_menu_local_actions_alter(),
 */
function MYMODULE_menu_local_actions_alter(&$local_actions) {
  if (isset($local_actions['foo.bar'])) {
    $local_actions['foo.bar']['options']['query']['destination'] = '/cheese';
  }
}
πŸ‡¦πŸ‡ΊAustralia sime Canberra

sime β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

For want of a better place to put this, I had this error with Group module. Group does not require "Create" access for the parent node, however I believe this was required for the media library while files were being uploaded on a new node form.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Let's move figuring out support for #3395096: Allow start date to be optional to the follow-up. We'll have to change the UI once we introduce the more complex set of settings, but we don't have to do that here.

So revert it to a checkbox is my takeaway from this? I did restructure things to be able to handle optional start date without any impacts on the config schema.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Oh boy I'm clearly out of practice with tokens and didn't even think of that. Thanks Jurgen, yes [user:uid:value] worked.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

In #39 ECA is mentioned and i've added ✨ Add ECA condition plugin "is TFA setup" Active as a related ticket.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Patch works for me, but regarding diffs and #19, someone would need to write the integration how https://www.drupal.org/project/entity_diff_ui β†’ does it for block/taxonomy/media.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

The current UI is confusing because we have the statement "Applies regardless of whether the field is required". This is not true. If the date range is not required and the end date is required then you are able to save a field without an end date. This is a good thing. But this text does not make it clear that this is the way this will be work.

Most of the difficulty around wording is because of the wording of the Required checkbox in the base/parent class. Do we want to explore unifying the two form elements (while retaining the underlying config structure)?

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Thanks. This makes a lot more sense what is going on. I'll leave this open for the moment and test some work arounds.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

I've made an issue for the UX issue.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

Thank you @anushri19 this is good progress. I've screenshot the current version below for UX team review and added the tag.

I've looked at the gitlab test output and I can't work out what might be failing due to this patch, i'm not sure what I'm missing something. I have rebased for good measure.

πŸ‡¦πŸ‡ΊAustralia sime Canberra

@smustgrave yes i have added a #4 TBA in the follow up issues, If no one objects i'll create that issue soon with my notes from investigating it.

Production build https://api.contrib.social 0.61.6-2-g546bc20