Contrib.social

[REDO} Resolve technical debt in initPackageManager()

Open on Drupal.org →
Created on 18 June 2024, 7 months ago
Updated 11 July 2024, 6 months ago

Problem/Motivation

Working on another issue i discovered that this code in initPackagerManager() appears to be no longer necessary and can be replaced with adding the modules to the $modules property.

Note that the issue in the todo has been resolved https://www.drupal.org/i/3349193 → . And I did have full passing tests removing this code at one point, hence I think it's ready to be resolved.

    // @todo Move back to static::$modules in https://www.drupal.org/i/3349193.
    $modules = [
      'package_manager_bypass',
      'package_manager',
      'package_manager_test_validation',
    ];
    try {
      $this->container->get('module_installer')->install($modules);
      // The container was rebuilt by the ModuleInstaller.
      $this->container = \Drupal::getContainer();
    }
    catch (MissingDependencyException $e) {
      $this->markTestSkipped($e->getMessage());
    }

Steps to reproduce

Proposed resolution

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇦🇺Australia sime Melbourne

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024