Detect and use phpstan.neon.dist if present

If this was merged right now it would break project_browser tests I think :D

FWIW there are around 22 contrib projects that have a phpstan.neon.dist file

It'd be great to test this change on any of those projects. You can create a temp issue to test this fork (https://project.pages.drupalcode.org/gitlab_templates/info/testing-mrs/). Code wise looks good, but I'd want to see a test on a project with it.

As I think about it more, if they have a .dist file, which isn't being used, we should leave it alone.

My understanding is that dist files are usually provided by applications or template packages, that provide their recommended configuration in dist files. "End users" are not supposed to use that extension. Instead they should omit that secondary extension.

That said, I agree with @sime in #8 and propose to close this issue as Won't fix.

Thanks for the discussion. Closing based on the above comments.

As this is "closed won't fix" could @fjgarlin or @sime close the merge request? I was about to re-base and re-test this as I came to it form the MR listing page not the issue.

fjgarlin → closed merge request !219

Thank you