MediaLibraryUiBuilder service does not properly allow additional contextual filter arguments

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Patch worked for me, and I've created the issue fork for it.

I confirm that this patch fixes the issue since i was having the same issue.

Confirmed working by me too.

Rebased and tests passing. There was an failed test that passwed when i reran.

I read the issue summary, comments and the MR. I do think that there should be a test here.

I also tried to test this but wasn't able to reproduce the problem. Following the steps to reproduce I found that the 'Grid' showed only media from the logged in user and the 'Table' showed media for all users. This was true with or without the diff applied. But, I seem to be in the minority here about that.

Still, I do recommend tests.

Amazing!
I debugged this for a while before commenting 🐛 Media Library view widgets do not support contextual filters Active and implementing a service decorator to modify $args...
This is a much nicer fix and works perfectly in my case as well.
I'll see if I can add tests on Monday.
Thanks

Added test. Setting back to needs review.

I have applied some changes that improve performance & optimize the resource usability of test code.

Keeping it in review for further suggestions.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

If my understanding is correct, any AJAX request inside the modal was causing the form ID to change resulting in an HTML response instead of JSON which JS can't process and we get AJAX "parsererror". Some more details here: #3142777-22: Media Library view widgets do not support contextual filters →
A quick way I used to debug was to click "Apply filters", then "Insert selected" -> Uncaught Drupal.AjaxError in console

Should we add something like this to the test for good measure?

// Submit exposed views filters.
$this->getSession()->getPage()->find('css', '#media-library-view')->pressButton('Apply filters');
$this->assertSession()->assertWaitOnAjaxRequest();
$this->waitForElementsCount('css', '#media-library-view .views-row', 2);

// Select and submit items.
$this->selectMediaItem(0);
$this->selectMediaItem(1);
$this->pressInsertSelected();

Besides that it looks great to me!

I have reviewed the recent changes in test code adding views handler programmatically instead of making http request improved the resource usage from Time: 00:22.841, Memory: 6.00 MB to Time: 00:16.287, Memory: 6.00 MB

Keeping it in review for further suggestions.

Seems the tests were skipped vs failing so wonder if they need some work.

#21, I had the same in this issue: 🐛 JS errors from Drupal.behaviors.activeLinks (... is not a valid selector) Needs work
Is the "Test-only changes" pipeline working correctly? Is it skipping FunctionalJavaScript tests for some reason?
I'm 99% sure tests in both issues fail as expected...

Asked in the #gitlab channel on Drupal slack and there was indeed a problem with the pipeline. See: 🐛 Test-only job cannot be run due to wrong dependency Fixed
It is now resolved. Rebased the fork and the tests seem to be triggering now: https://git.drupalcode.org/issue/drupal-3401726/-/pipelines/249631