🇨🇦Canada @pavlosdan

I'm thinking it may be better to split the constraint message into upper limit message and lower limit message so we don't risk losing context if the %min_max string gets translated. The %min_max token can then be removed.

Thoughts? Making this into a bug rather than a feature request as the strings should be translatable.

Thank you for the reviews and suggestions @acbramley!

Change record added https://www.drupal.org/node/3424780 → and issue summary updated.

I endorse Matt for this role as well. He's proven his skills in the Drupal update field time and again with contributions that help such as phpstan, drupal-check, and retrofit. No doubt, Matt will be an excellent and integral addition to the team!

Created a new branch from 11.x and cherrypicked the commits onto it.

Setting this back to needs review. The issues in #39, #47 seem to have been addressed except no1 in #39 which I don't think is out of scope since we need content moderation to be testing for taxonomy_term entity as well which may have a different entity key for label than other entities which may use "title".

pavlosdan → made their first commit to this issue’s fork.

pavlosdan → created an issue.

Thanks for testing this @Sandeep_k. Pushed a commit to fix the issue!

pavlosdan → created an issue.

Thanks larowlan!

Installing a site from existing config using Drupal 10.2 and Workbench Email 3.0.2 throws the following errors:

[error]  Unexpected error during import with operation create for workbench_email.workbench_email_template.to_published: Route "entity.workbench_email_template.canonical" does not exist. 
 [error]  Unexpected error during import with operation create for workbench_email.workbench_email_template.to_archived: Route "entity.workbench_email_template.canonical" does not exist. 
 [error]  Unexpected error during import with operation create for workbench_email.workbench_email_template.to_published: Route "entity.workbench_email_template.canonical" does not exist. 

Re-opening as the issue is not solved even with the workaround in place.

Steps to reproduce:
- Install a site using the Standard profile
- Enable Content Moderation and Content Translation modules (content moderation will give us the moderated content admin dashboard which has this issue "/admin/content/moderated")
- Assign the "Editorial" workflow that gets created when enabling the content moderation module to the Article content type.
- Add a second language to the site, e.g French.
- Enable translation on the Article content type.
- Add an Article node and mark it as published.
- Add a translation for the article node that was just added but mark it as draft.
- Visit "/admin/content/moderated" and observe that the Content Type column for our translated node will have no information in it.

• Added compatibility for Drupal 10.
• Minor language adjustments and coding standard fixes.
• On the translation edit form used access = FALSE instead of class hidden to prevent entrepreneurial users from removing the class from the HTML and making changes.

pavlosdan → made their first commit to this issue’s fork.

Had a chat with Martin the other day about this. Here's a patch to hopefully unblock people until we get a fix incorporated into Site Studio.

Please review and let us know if this works.

I was able to replicate this for content types as well by adding a layout canvas field to it. Not sure why adding a media reference field makes it work as the key issue seems to be that Site Studio is looking for the form submit button within the

`#${drupalSettings.cohesion.drupalFormId} input[type="submit"]` 

I've recommended to the Site Studio team that the selector be changed to the following

const defaultSubmitEl = document.querySelectorAll(
  `input[type="submit"][form="${drupalSettings.cohesion.drupalFormId}"]`
)[0];

so the submit button can be found wherever it is placed as Gin places the buttons outside of the form which is still valid https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-form)

Marking this as "postponed" until we see whether Site Studio will be able to incorporate the change. Meanwhile if people find any good workarounds, merge requests are welcomed.

The patch is indeed incorporated into Site Studio now and is no longer needed. Closing this.

I can't replicate this with Gin 3.0.0-rc3, Site Studio 7.1.0, and Site Studio Gin 1.0.0 and a basic content type with only a body field on it.

Is this still an issue?

https://git.drupalcode.org/project/paragraphs_limits/-/blob/8.x-1.0-alph...

The code from the patch is present in alpha5. Is the issue not resolved @PCate?

Thanks all, merged.

pavlosdan → made their first commit to this issue’s fork.

Patch applied and merged.

pavlosdan → made their first commit to this issue’s fork.

pavlosdan → made their first commit to this issue’s fork.

Updated merge request to address #13

Thanks for taking it for a spin and the feedback @chrisrhymes! Setting it back to needs work to address findings in #13.

Built on @hershy.k's work to hopefully get this through the finish line or nearer to it.

Made adjustments to support multiple buttons since multiple paragraph embed buttons can be added.

pavlosdan → made their first commit to this issue’s fork.

pavlosdan → created an issue.

pavlosdan → created an issue.