- πΊπΈUnited States bakulahluwalia Houston
We switched the theme from Gin to Claro till we have any patch or fix available. Legit issue.
- Status changed to Postponed: needs info
over 1 year ago 3:20am 24 May 2023 - π¨π¦Canada pavlosdan
I can't replicate this with Gin 3.0.0-rc3, Site Studio 7.1.0, and Site Studio Gin 1.0.0 and a basic content type with only a body field on it.
Is this still an issue?
- πΊπΈUnited States kevinfunk
@pavlosdan can you test with Component content?
I can replicate the issue trying to create Component content using Drupal 10.0.9, Gin 3.0-rc3, Site Studio 7.1.1, and Site Studio Gin 1.0.0.
- π«π·France aamouri
Hello,
I have the same problem when I try to save a site studio component content.
I will try to find a workaround with a patch.
Thx.
- Status changed to Postponed
over 1 year ago 7:34pm 24 May 2023 - π¨π¦Canada pavlosdan
I was able to replicate this for content types as well by adding a layout canvas field to it. Not sure why adding a media reference field makes it work as the key issue seems to be that Site Studio is looking for the form submit button within the
`#${drupalSettings.cohesion.drupalFormId} input[type="submit"]`
I've recommended to the Site Studio team that the selector be changed to the following
const defaultSubmitEl = document.querySelectorAll( `input[type="submit"][form="${drupalSettings.cohesion.drupalFormId}"]` )[0];
so the submit button can be found wherever it is placed as Gin places the buttons outside of the form which is still valid https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-form)
Marking this as "postponed" until we see whether Site Studio will be able to incorporate the change. Meanwhile if people find any good workarounds, merge requests are welcomed.
- π¨π¦Canada pavlosdan
Had a chat with Martin the other day about this. Here's a patch to hopefully unblock people until we get a fix incorporated into Site Studio.
Please review and let us know if this works.
- Status changed to Needs review
over 1 year ago 10:21pm 5 June 2023 - @pavlosdan opened merge request.
- Status changed to RTBC
over 1 year ago 1:47am 6 June 2023 - Status changed to Needs work
over 1 year ago 2:07am 6 June 2023 - πΊπΈUnited States kevinfunk
I'm getting an error when trying to edit a Webform.
Error: Call to undefined method Drupal\webform\Entity\Webform::getFieldDefinitions() in sitestudio_gin_form_alter() (line 114 of /sitestudio_gin/sitestudio_gin.module).
- Status changed to Needs review
over 1 year ago 3:17am 6 June 2023 - πΊπΈUnited States kevinfunk
Patch should fix issues with all entities that are not fieldable.
- Status changed to RTBC
over 1 year ago 7:37pm 27 June 2023 - First commit to issue fork.
-
mandclu β
committed 0b961b7f on 1.0.x
Issue #3358530 by pavlosdan, kevinfunk, Rajeshreeputra: Unable to save...
-
mandclu β
committed 0b961b7f on 1.0.x
- Status changed to Fixed
21 days ago 4:49pm 25 October 2024 Automatically closed - issue fixed for 2 weeks with no activity.