🇺🇸United States @kevinfunk

kevinfunk → created an issue.

kevinfunk → created an issue.

kevinfunk → created an issue.

If you are using Gin and Gin Toolbar, you will also want to use the patch from Edit link in breadcrumb region shows even when user has no permission 🐛 Edit link in breadcrumb region shows even when user has no permission Needs review .

kevinfunk → created an issue.

kevinfunk → created an issue.

I also addressed Remove 8.7.x fallback code for TaxonomyTestTrait → since the support for D8 was dropped. Please let me know if you want me to add it back and created a new MR for Remove 8.7.x fallback code for TaxonomyTestTrait → .

kevinfunk → created an issue.

MR applies and allows me to send Webform results to Mauitc on my D11 test site.

Thank you @wolfhowling for creating the issue. The patch did not apply to 8.x-1.x-dev so I created the MR to address the following:

FILE: web/modules/contrib/tac_lite/src/Form/SchemeForm.php

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Fix now 37 Call to deprecated function user_roles(). Deprecated in
drupal:10.2.0 and is removed from drupal:11.0.0. Use
Drupal\user\Entity\Role::loadMultiple() and, if necessary,
an inline implementation instead.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/tac_lite/tac_lite.info.yml

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 6 Value of core_version_requirement: ^8 || ^9 || ^10 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/tac_lite/tac_lite_create/tac_lite_create.info.yml

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 6 Value of core_version_requirement: ^8 || ^9 || ^10 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

I have also tested this on a Drupal 11 sites with the changes from the MR.

kevinfunk → made their first commit to this issue’s fork.

I was able to apply the MR on my Drupal 11 site and recreate the Example Use Case.

Applied MR and was able to install the Entity comparison module and compare two products.

I set the version to >=9 so it should make it easier moving forward. To get around patching api-library to work with D10 or D11 (see https://github.com/mautic/api-library/issues/273), I have set it to allow using the main branch.

kevinfunk → created an issue.

kevinfunk → created an issue.

With the MR applied on my Drupal 11 site, I was able to change the order of the tabs, set a custom label, add a custom class, and disable a tab.

+1 that the patch from #29 fixes the issue.
I was seeing the issue using the Acquia DAM module and it happened when DAM was selected when the modal was opened.

kevinfunk → created an issue.

You can do this by using a token for the title. Set the prev/next labels to [node:title].

A patch for the temporary solution.

kevinfunk → created an issue.

kevinfunk → created an issue.

kevinfunk → created an issue.

kevinfunk → created an issue.

@eleonel, I wasn't able to reproduce your issue in #3402694 🐛 Issue with Tags Widget Incorrectly Parsing Augmentor Results Fixed so I'm not sure if this introduces that issue again.

kevinfunk → created an issue.

Good call @mandclu. I've update the MR to require Site Studio 7.

Thanks @mglaman.

@nireneko can you update the MR to remove parent: menu.active_trail? I've manually made the change and it worked so once the MR has been updated, I should be able to set it to RTBC.

I've tested with Drupal 10.2.0-rc1 and it does fix the issue. However, on 10.1.7 I'm getting the error

TypeError: Drupal\gin_toolbar\Menu\GinToolbarActiveTrail::__construct(): Argument #1 ($container) must be of type Drupal\Component\DependencyInjection\ContainerInterface, Drupal\Core\Menu\MenuLinkManager given, called in /home/ide/project/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\gin_toolbar\Menu\GinToolbarActiveTrail->__construct() (line 33 of /home/ide/project/docroot/modules/contrib/gin_toolbar/src/Menu/GinToolbarActiveTrail.php).

Thanks @saschaeggi.

kevinfunk → changed the visibility of the branch 8.x-3.x to hidden.

@djsagar I believe my patch from #7 is a more elegant approach.

It happens when there is an extra long page title.
I've tested with "Proin tempor aliquam orci, pretium egestas justo cursus id. Fusce et massa ac lorem sollicitudin sollicitudin. Duis vel."

Applied diff as a patch using composer patches and it fixes the issue.

Reroll for 2.x

Tested the MR with Drupal 10.1.6 and Gin 3.x-dev and it fixes the chrevrons on the collapse sidebar button.

kevinfunk → created an issue.

Uploading a patch for testing.

kevinfunk → created an issue.

Thank you saschaeggi for working on this. I found this issue today and the MR didn't solve the issue. I've attached a patch and diff of my changes that worked.

To test

• Install Drupal minimal profile
• Install Toolbar module
• Install Gin theme
• Set Gin as Administration theme
• Configure Gin to use "New Drupal Navigation, Test integration"

@tdnshah thank you for working on this. Because we are requiring jQuery UI Autocomplete, we will need a Composer file to add the module.

+1. It would be great to have a UI to turn it on/off.

caesius → credited kevinfunk → .

Created a new MR from my comments in #9 📌 Automated Drupal 10 compatibility fixes Fixed .

@Krzysztof Domański, file_create_url() → was deprecated in 9.3.x. To use file_url_generator, core_version_requirement needs bumped to core_version_requirement: ^9.3 || ^10. Please see #10 📌 Automated Drupal 10 compatibility fixes RTBC .

-  $variables['logo'] = file_url_transform_relative(file_create_url(theme_get_setting('logo.url')));
+  $variables['logo'] = \Drupal::service('file_url_generator')->generateString(theme_get_setting('logo.url'));

file_url_transform_relative() → was deprecated in 9.3.x. To use file_url_generator, core_version_requirement needs bumped to core_version_requirement: ^9.3 || ^10

@jonathan1055 I am using Drush 11.6.0.
The example for function hook_config_import_steps_alter does not show a type hint for $context. I think it has to do with it being a batch. I also found an issue for Queue UI where they had an issue with the type hint #3313894 → .

Is 8.x-1.x-dev still supported? I can confirm that this is not an issue with Drupal 10.0.1 and Entity Clone 2.0.0-beta4.

kevinfunk → created an issue.

kevinfunk → created an issue.

Removes the extra return after the use statement.

@andy_w, thanks for providing a possible solution.
When testing I got the error Error: Class "Markup" not found in admin_toolbar_page_attachments() (line 99 of /var/www/html/docroot/modules/contrib/admin_toolbar/admin_toolbar.module). Adding use Drupal\Core\Render\Markup; allowed me to test your solution. It does work and I'm happy to use it until a better solution is provided. I can create an updated patch if you don't get to it before me :)

Turning off CSS Aggregation doesn't fix the issue for me. I also see the issue using Claro with Admin Toolbar using Drupal 10.1.

kevinfunk → made their first commit to this issue’s fork.

Patch should fix issues with all entities that are not fieldable.

I'm getting an error when trying to edit a Webform.
Error: Call to undefined method Drupal\webform\Entity\Webform::getFieldDefinitions() in sitestudio_gin_form_alter() (line 114 of /sitestudio_gin/sitestudio_gin.module).

The patch has unblocked me!

@justcaldwell, thanks for the review!

Should the delete button be updated?

.ui-dialog-off-canvas #drupal-off-canvas .moderation-sidebar-link.button.button--danger {
  color: var(--gin-color-danger) !important;
  border-color: var(--gin-color-danger) !important;
}

.ui-dialog-off-canvas #drupal-off-canvas .moderation-sidebar-link.button.button--danger:hover {
  color: var(--gin-color-button-text) !important;
  background: var(--gin-color-danger) !important;
}

kevinfunk → created an issue.

@pavlosdan can you test with Component content?

I can replicate the issue trying to create Component content using Drupal 10.0.9, Gin 3.0-rc3, Site Studio 7.1.1, and Site Studio Gin 1.0.0.

kevinfunk → created an issue.

kevinfunk → created an issue.

@aziza_a, thank you for your patch! It works great with Drupal 10.0.9.

@darvanen, sorry, I didn't check to make sure the js files were updated when I ran my tests. Everything should be good now.

I've tested the updated MR and it solves the issue.
@darvanen that works too. Thanks for the teamwork @akshaydalvi212!

kevinfunk → created an issue.

@dharmendart the patch was for 8.x-1.x-dev. 8.x-1.x-dev was updated so you do not need to apply the patch when using 8.x-1.x-dev.

Made a few fixes from the patch.

kevinfunk → made their first commit to this issue’s fork.