Drupal 11 compatibility

Created on 2 April 2024, about 1 year ago

Problem/Motivation

Hi, I recently found this module very helpful and I would like to see it compatible with versions greater than D9. Since the community is preparing for D11 this year, I thought I would start an issue to make it compatible with Drupal 11.

modules/views_override_viewmode/views_override_viewmode.info.yml

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 Value of core_version_requirement: ^8 || ^9 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States kevinfunk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kevinfunk
  • Merge request !1Adds D11 compatibility. → (Merged) created by kevinfunk
  • Status changed to Needs review about 1 year ago
  • 🇮🇳India sarwan_verma

    Hi @kevinfunk,
    I have fixed this issue "Drupal 11 compatibility" and also attached patch,
    please review and verify.

  • First commit to issue fork.
  • 🇺🇸United States jcandan

    Not sure why, but MR !1 is giving me errors when I attempt to use the patch.

            "patches": {
                "drupal/views_override_viewmode": {
                    "Drupal 11 compatibility": "https://git.drupalcode.org/project/views_override_viewmode/-/merge_requests/1/diffs.diff"
                }
            },
    
    Gathering patches for dependencies. This might take a minute.
      - Installing drupal/views_override_viewmode (1.0.0-beta1): Extracting archive
      - Applying patches for drupal/views_override_viewmode
        https://git.drupalcode.org/project/views_override_viewmode/-/merge_requests/1/diffs.diff (Drupal 11 compatibility)
       Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/views_override_viewmode/-/merge_requests/1/diffs.diff
    
    In Patches.php line 331:
                                                                                                                                              
      Cannot apply patch Drupal 11 compatibility (https://git.drupalcode.org/project/views_override_viewmode/-/merge_requests/1/diffs.diff)!  
    

    Also tried with the .patch extension.

    We can probably close 📌 Automated Drupal 10 compatibility fixes RTBC in lieu of this update when it is fixed.

  • 🇺🇸United States jcandan

    Seems this is a known bug: 🐛 patches to info.yml files are created against the wrong version and don't apply Active .

    The problem was with the whitespace at the end of the file, which is Drupal coding standard.

    I'll test without that whitespace and see if 🐛 D10 upgrade ? Active is still an issue. If it all good, we'll re-add the whitespace to the merge request and consider this RTBC.

  • 🇺🇸United States jcandan

    I was able to get this working on 10.4.0 and 11.10. Marking RTBC.

  • 🇺🇸United States jcandan
  • 🇺🇸United States jcandan

    Use the merge request.

  • 🇺🇸United States jcandan

    Actually, one thing...let's support Drupal 10+ only. Drupal 9 reached end-of-life. Drupal 10 is supported until Drupal 12.

    I was going to address this in a follow-up issue, but that's probably not necessary.

    While there may be some use of this module, this module is still in development and pending a beta pre-release. I think we're within rights to deprecate outdated Drupal core support without bumping major version for a breaking change.

    Removing Drupal 8 and 9 support.

  • 🇺🇸United States jcandan

    Dropped support for Drupal 8 and Drupal 9.

    Re-added the newline at end of file noted in #6 Drupal 11 compatibility Active .

    RTBC. MR !1 is ready to merge.

  • Status changed to Fixed about 1 month ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024