- π©πͺGermany dbielke1986
Hi @all,
Drupal 10 is released and over 2600 sites are reported to use this module.
It would be great to see this patch in a new official version.
Is there a chance to get this merged?BR
Daniel - First commit to issue fork.
This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module β , even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.yml
file for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot β to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #12554This patch was created using these packages:
- mglaman/phpstan-drupal: 1.1.35
- palantirnet/drupal-rector: 0.15.1
- @o_tymoshchuk opened merge request.
- πΊπ¦Ukraine o_timoshchuk
I created a patch for version 6.0 of the module and tested it on Drupal 10.1.1, and it seems to be working well.
- πΊπΈUnited States kevinfunk
- $variables['logo'] = file_url_transform_relative(file_create_url(theme_get_setting('logo.url'))); + $variables['logo'] = \Drupal::service('file_url_generator')->generateString(theme_get_setting('logo.url'));
file_url_transform_relative() β was deprecated in 9.3.x. To use file_url_generator,
core_version_requirement
needs bumped tocore_version_requirement: ^9.3 || ^10
- Status changed to RTBC
over 1 year ago 8:52pm 18 July 2023 - π©πͺGermany vincent.hoehn Dresden, Germany
The patch works great, okay for merge. That's why I'm changing the status to RTBC!
- @kevinfunk opened merge request.
- Status changed to Needs review
over 1 year ago 11:23pm 18 July 2023 - πΊπΈUnited States kevinfunk
Created a new MR from my comments in #9 π Automated Drupal 10 compatibility fixes Fixed .
- Status changed to RTBC
over 1 year ago 2:25pm 8 August 2023 - π©πͺGermany vincent.hoehn Dresden, Germany
I'm fine with the merge request @kevinfunk. I hope this get merge quickly.
-
dbielke1986 β
committed 36cfbf07 on 7.0.x authored by
kevinfunk β
Issue #3298075 by o_tymoshchuk: Automated Drupal 10 compatibility fixes
-
dbielke1986 β
committed 36cfbf07 on 7.0.x authored by
kevinfunk β
- Status changed to Fixed
over 1 year ago 1:20pm 6 September 2023 - Status changed to Fixed
over 1 year ago 6:30am 7 September 2023 - π©πͺGermany vincent.hoehn Dresden, Germany
Thank you very much! Works great.