Drupal 11 compatibility fixes

Thank you @wolfhowling for creating the issue. The patch did not apply to 8.x-1.x-dev so I created the MR to address the following:

FILE: web/modules/contrib/tac_lite/src/Form/SchemeForm.php

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Fix now 37 Call to deprecated function user_roles(). Deprecated in
drupal:10.2.0 and is removed from drupal:11.0.0. Use
Drupal\user\Entity\Role::loadMultiple() and, if necessary,
an inline implementation instead.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/tac_lite/tac_lite.info.yml

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 6 Value of core_version_requirement: ^8 || ^9 || ^10 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/tac_lite/tac_lite_create/tac_lite_create.info.yml

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 6 Value of core_version_requirement: ^8 || ^9 || ^10 is not
compatible with the next major version of Drupal core. See
https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

I have also tested this on a Drupal 11 sites with the changes from the MR.

MR !12 looks fine to me…?
Doesn't MR !13 break backward compatibility to D8 and D9 ?

The #MR13 works for both Drupal 10 and Drupal 11. Attaching the upgrade status screenshot for reference. Moving the issue to RTBC.

@abhi_khandelwal, you are correct when you write:

The #MR13 works for both Drupal 10 and Drupal 11.

The green status in your capture means: «Compatible with next major Drupal core version». That's only when looking forward.

But we also need to look backward. MR !13 will break past Drupal core versions i.e. Drupal 8.x and 9.x, because of it introduces a restriction: core_version_requirement: ^10 || ^11, and we don't want that.

Here are examples of other modules that were recently changed to be D11 compatible without removing backward compatibility, if you look at he plain diff you'll see something like: core_version_requirement: ^8 || ^9 || ^10 || ^11

• https://www.drupal.org/project/protected_pages/issues/3485965 💬 Drupal 11 Compatibility Needs work
• https://www.drupal.org/project/scheduler/issues/3434325 📌 Automated Drupal 11 compatibility fixes for scheduler Active
• https://www.drupal.org/project/registration_role/issues/3470959 🐛 Drupal 11 - Update Code - Needs review

And this is also exactly what you'll see in @kevinfunk MR !12 where backward compatibility to D8 and D9 is preserved.

MR13 works for me using Drupal 11.1.7, thanks.

vladimiraus → changed the visibility of the branch 3493862-drupal-11-compatibility to hidden.

Thank you for your contributions.
Committed. 🧁