Add settings tray/off-canvas styles

Should the delete button be updated?

.ui-dialog-off-canvas #drupal-off-canvas .moderation-sidebar-link.button.button--danger {
  color: var(--gin-color-danger) !important;
  border-color: var(--gin-color-danger) !important;
}

.ui-dialog-off-canvas #drupal-off-canvas .moderation-sidebar-link.button.button--danger:hover {
  color: var(--gin-color-button-text) !important;
  background: var(--gin-color-danger) !important;
}

Hi @kevinfunk,
Yeah, great idea and it looks great on first pass. Would you be able to add the delete button styling to the MR?
Thanks for contributing!

@justcaldwell, thanks for the review!

Thanks for updating the MR. I did some more in-depth testing on both Drupal 9 and 10. I'm seeing a minor contrast issue for the 'Use custom log message' label on Drupal 9 only (Gin light mode). See attached screenshot.

More importantly, these changes introduce some contrast issues and inconsistent styling for "non moderation sidebar" settings tray styles (e.g. Layout Builder). These appear in both D9 and D10 with some slight variation — screenshots below are from Drupal 10. Gin light mode only. Dark mode seems to work well.

Given that Gin takes a pretty light hand with settings tray styling — Gin doesn't add "light mode" styles for settings tray, for example — at the moment I'm inclined to follow that lead and not add them here, but I'm open to further discussion.

Thanks for your work here. As indicated above, I'm going to follow Gin's lead here and not try to style the settings tray itself.

The idea is worth further consideration/discussion — maybe as a feature request in the Gin issue queue, and/or a dedicated module for off-canvas styles?

justcaldwell → closed merge request !4