Gin Toolbar incompatible with 10.2.0-beta1 - MenuActiveTrail ($menu_link_manager) must be of type Menu\MenuLinkManagerInterface, DependencyInjection\Container given

Looks like the GitLab CI pipeline was broken before I and my changes entered the stage, so going to put this on Needs Review despite the red flags there.

This worked nicely with Drupal 10.2 RC1 and solved my issue.

#4 MR fixed the issue for gin toolbar module on drupal 10.2.x

The MR just removes our modified menu trail service gin_toolbar.active_trail and swaps it for the core one which defeats the purpose of it. So this needs work to instead fix our service than removing it.

Updated the branch with another solution.

The problem could be that Drupal tries to inject container and the proxy ID of the parent service because now is lazy.

Yes it seems now we are not getting the issue with the latest solution.

We can also add
lazy: true to gin_toolbar.services.yml

Can somebody test the new solution from the MR so we can move ahead with a solution here?

@mahtab_alam

lazy: true to gin_toolbar.services.yml

We might want to add it.

Thank y'all in advance

I've tested with Drupal 10.2.0-rc1 and it does fix the issue. However, on 10.1.7 I'm getting the error

TypeError: Drupal\gin_toolbar\Menu\GinToolbarActiveTrail::__construct(): Argument #1 ($container) must be of type Drupal\Component\DependencyInjection\ContainerInterface, Drupal\Core\Menu\MenuLinkManager given, called in /home/ide/project/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\gin_toolbar\Menu\GinToolbarActiveTrail->__construct() (line 33 of /home/ide/project/docroot/modules/contrib/gin_toolbar/src/Menu/GinToolbarActiveTrail.php).

I think the fix to support 10.1 and 10.2 is to add lazy: true and generate a proxy service as well.

This worked for me:

+     arguments: ['@plugin.manager.menu.link', '@current_route_match', '@cache.menu', '@lock']
-      parent: menu.active_trail

Remove the parent declaration. No need to modify constructor.

It works, thanks @mglaman.

Thanks @mglaman.

@nireneko can you update the MR to remove parent: menu.active_trail? I've manually made the change and it worked so once the MR has been updated, I should be able to set it to RTBC.

#22 - I can confirm that removing parent: menu.active_trail in the gin_toolbar.services.yml manially, and clearing the cache fixes the issue for me.

Can confirm the same as #23 on the actual release of 10.2: the patch from MR !37 + removing that the parent: menu.active_trail line clears the error.

@kevinfunk, done!

This broke our sites tonight with the 10.2 release of Drupal core. The latest version of the MR as of #25 fixes the issue for us.

+1 for the patch, it resolves the 10.2 compatibility bug.

Tested on Drupal 9.2, 9.5, 10.0, 10.1 & 10.2

Let's get this merged!

Released: https://www.drupal.org/project/gin_toolbar/releases/8.x-1.0-rc5 →

Thanks y'all for participating in fixing this 👏

Cool :) I wonder if this could be "fixed" later using service decoration and checking the active theme (if Gin, do logic, otherwise delegate to inner) to avoid any further breaking changes.

Automatically closed - issue fixed for 2 weeks with no activity.

I'm repeatedly getting this error on one of my sites after updating to Drupal 10.2.2 and Gin Toolbar 8.x-1.0-rc5. Even after clearing the cache and running all database updates. Not sure what the problem is since it seems like everything is up-to-date.