Account created on 11 March 2013, over 11 years ago
#

Merge Requests

More

Recent comments

πŸ‡ͺπŸ‡ΈSpain nireneko

With versiΓ³n 6 of simple_auth you also need https://www.drupal.org/project/simple_oauth_password_grant β†’ , because password grant was removed and entity_share uses password to authenticate the users.

πŸ‡ͺπŸ‡ΈSpain nireneko

Fixed :)

This need another check for anonymous users, but for now it works as expected.

πŸ‡ͺπŸ‡ΈSpain nireneko

I have the same error, the problem could be because in the parent constructor of Drupal\cdn_ui\Form\ValidatableConfigFormBase, the property typedConfigManager is set to null there. Changing the order of the call to parent constructor fixes the issue for me.

πŸ‡ͺπŸ‡ΈSpain nireneko

Updated the branch with another solution.

The problem could be that Drupal tries to inject container and the proxy ID of the parent service because now is lazy.

πŸ‡ͺπŸ‡ΈSpain nireneko

I checked this, and I can't find the problem, but like @borisson_ sais, must be in the config, debugging the core.extensions.yml file has the full list of modules that must be installed, but when the syncronization is executed in the test ConfigImportAllTest lines:

$this->drupalGet('admin/config/development/configuration');
$this->submitForm([], 'Import all');

Is not installing all the modules.

I tried to debug the syncronization import in Drupal\config\Form\ConfigSync, but I can't :(

Getting the list of enabled modules before

// Check that all modules that were uninstalled are now reinstalled.
    $this->assertModules(array_keys($modules_to_uninstall), TRUE);

line, there are 26 installed modules of 74.

Also something strange, in the new validator EntityExistsConstraintValidator, adding one "return;" before add the violation (or removing the violation), the test is green and I don't understand why, because in my case, that point never is reached, the 'if' always is 'true'.

    // If we can load an entity of the given type with the ID in value we pass
    // the constraint.
    if ($this->entityTypeManager->getStorage($constraint->entityType)->load($value)) {
      return;
    }

    return;

    $violation = $this->context
      ->buildViolation($constraint->message)
      ->setParameter('@entity_type', $constraint->entityType)
      ->setParameter('%value', $value);
    $violation->addViolation();
πŸ‡ͺπŸ‡ΈSpain nireneko

Like suggested by @g089h515r806, overrided some constraints to replace the message strings.

This is the list of Symfony constraints with dependency on intl component:

  • Bic
  • Currency
  • Language
  • Locale
  • Timezone

I didn't touch that constraints because we must add a new requirement in composer.json, the php extension "intl", and I think, that should be done in Drupal 11, no in 10.X ?

πŸ‡ͺπŸ‡ΈSpain nireneko

nireneko β†’ made their first commit to this issue’s fork.

πŸ‡ͺπŸ‡ΈSpain nireneko

To add the validation of greater than 0 we have this Symfony constraint https://symfony.com/doc/current/reference/constraints/GreaterThan.html
But I found this issue to add all the missing constraints https://www.drupal.org/project/drupal/issues/3365498 πŸ“Œ Add Missing Symfony Validators to Drupal Constraint Validator Needs work , I don't know if we should wait until that task is finished before continue working in this one, or just add the constraints that we need here.

πŸ‡ͺπŸ‡ΈSpain nireneko

@smustgrave I used regex for the same reason, couldn't find one constraint to check types.

But I added a new constraint extending https://symfony.com/doc/current/reference/constraints/Type.html because is a better solution, and now we have one constraint to check types :)

πŸ‡ͺπŸ‡ΈSpain nireneko

Added link to Slack channel.

πŸ‡ͺπŸ‡ΈSpain nireneko

nireneko β†’ made their first commit to this issue’s fork.

πŸ‡ͺπŸ‡ΈSpain nireneko

nireneko β†’ made their first commit to this issue’s fork.

πŸ‡ͺπŸ‡ΈSpain nireneko

@shanilkns I had the same issue, and in my case the problem was Facets module, the patch of this issue solves the issue. https://www.drupal.org/project/facets/issues/3379445 πŸ› Facets breaks all AJAX views that uses pagers even without facets Fixed

Production build 0.71.5 2024