- Issue created by @idflorin
- First commit to issue fork.
- šŖšøSpain nireneko
I have the same error, the problem could be because in the parent constructor of Drupal\cdn_ui\Form\ValidatableConfigFormBase, the property typedConfigManager is set to null there. Changing the order of the call to parent constructor fixes the issue for me.
- Status changed to Needs review
11 months ago 9:45am 18 December 2023 - last update
11 months ago 228 pass, 2 fail - š®š³India dineshkumarbollu
Hi
By changing the order of the call to parent constructor fixes the issue. i am provided patch for this.
Thanks The last submitted patch, 5: 3409258-5.patch, failed testing. View results ā
- Status changed to Needs work
11 months ago 12:13pm 18 December 2023 - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Now that š Adopt GitLab CI: PHPStan compliance + test against 9.5/10.0/10.1/10.2/11.x + max PHP version Fixed has landed, tests are running against Drupal 10.2. But ā¦ the
cdn_ui
module has no test coverage. So it won't be noticeable in GitLab CI pipelines.Still, let's be pragmatic:
- this is the only actual blocker for using the CDN module in Drupal 10.2
- ā¦ but tests are failing against Drupal 10.2 due to trivial HTML markup changes in 10.2 (root cause:
š
Upgrade filter system to HTML5
Fixed
):
1) Drupal\Tests\cdn\Kernel\EditorFileReferenceFilterTest::testEditorFileReferenceFilter Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'<img src="/vfs://root/sites/simpletest/67961676/files/llama.jpg" data-entity-type="file" data-entity-uuid="4543901c-cb0b-4e3b-a286-edf2ebeb26c0" />' +'<img src="/vfs://root/sites/simpletest/67961676/files/llama.jpg" data-entity-type="file" data-entity-uuid="4543901c-cb0b-4e3b-a286-edf2ebeb26c0">' ā¦
So let's update the test assertions for 10.2 here too.
-
Wim Leers ā
committed aeeb9e06 on 4.x
Issue #3409258 by nireneko, Wim Leers, dineshkumarbollu, idflorin, loze...
-
Wim Leers ā
committed aeeb9e06 on 4.x
- Status changed to Fixed
11 months ago 11:35am 22 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.