Add validation constraints to taxonomy.settings

I wonder if we need this regex to check if it is a number. I wonder if this is the right solution, @Wim what do you think?

I was searching core for type: integer and couldn't find any other example. I would of assumed though just being type integer would come with a constraint to be a number.

@smustgrave I used regex for the same reason, couldn't find one constraint to check types.

But I added a new constraint extending https://symfony.com/doc/current/reference/constraints/Type.html because is a better solution, and now we have one constraint to check types :)

Nice solution!

Left some feedback on the MR 😊

To add the validation of greater than 0 we have this Symfony constraint https://symfony.com/doc/current/reference/constraints/GreaterThan.html
But I found this issue to add all the missing constraints https://www.drupal.org/project/drupal/issues/3365498 📌 Add Missing Symfony Validators to Drupal Constraint Validator Needs work , I don't know if we should wait until that task is finished before continue working in this one, or just add the constraints that we need here.

Back to NR after one commit and some feedback on the MR.

Believe that change should be good.

TypeConstraint is out of place here. See MR for details.

With my limited schema knowledge believe this is good. Least didn't cause any failures.

I agree with @smustgrave, this looks great.

I disagree 😇 There's one line in there that shouldn't be.

Change that wim requested in #19 has been fixed. Back to rtbc.

RTBC++

lauriii → closed merge request !5091

Committed 5e2a94e and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.