- Issue created by @Spokje
- Status changed to Postponed
8 months ago 10:36am 27 October 2023 - 🇳🇱Netherlands Spokje
Postponing on the possible adoption of native Symfony lazy services in 📌 Deprecate Drupal ProxyBuilder in favor of Symfony lazy services Closed: won't fix .
- Assigned to Spokje
- Status changed to Active
8 months ago 12:23pm 29 October 2023 - 🇳🇱Netherlands Spokje
📌 Deprecate Drupal ProxyBuilder in favor of Symfony lazy services Closed: won't fix is trickier than expected, let's not postpone better on perfect here.
- @spokje opened merge request.
- Status changed to Needs review
8 months ago 3:04pm 29 October 2023 - Status changed to RTBC
8 months ago 2:42pm 2 November 2023 - 🇺🇸United States smustgrave
Pipeline is green and CR has the main points.
Almost marked because the syntax in the generated classes seemed off but checking others guess that's the case of how they get generated. And gitlabCI didn't complain.
If this gets in should the scope of 📌 Deprecate Drupal ProxyBuilder in favor of Symfony lazy services Closed: won't fix be expanded?
- Issue was unassigned.
- Status changed to Fixed
8 months ago 9:56pm 14 November 2023 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!
- 🇬🇧United Kingdom Hephaestus
This change appears to be causing the issue discussed in 🐛 MenuActiveTrail ($menu_link_manager) must be of type Menu\MenuLinkManagerInterface, DependencyInjection\Container given Active after upgrading to 10.2.0-beta1.
Automatically closed - issue fixed for 2 weeks with no activity.