- Issue created by @kevinfunk
- last update
almost 2 years ago 14 pass - @kevinfunk opened merge request.
- Status changed to Needs review
almost 2 years ago 2:24am 5 May 2023 - Status changed to Needs work
almost 2 years ago 2:51am 5 May 2023 - 🇦🇺Australia darvanen Sydney, Australia
Thank you for the input but I'd rather not diable babel entirely, could you try this instead?:
.pipe(require('gulp-babel')({ presets: [['@babel/preset-env', { modules: false }]] }))
- Assigned to akshaydalvi212
- 🇮🇳India akshaydalvi212
I will replace the code with the suggested script in #4.
- last update
almost 2 years ago 14 pass - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 11:49am 5 May 2023 - 🇮🇳India akshaydalvi212
updated the MR as per suggestion #4.
kindly review. - Status changed to RTBC
almost 2 years ago 12:03pm 5 May 2023 - 🇺🇸United States kevinfunk
I've tested the updated MR and it solves the issue.
@darvanen that works too. Thanks for the teamwork @akshaydalvi212! - Status changed to Needs work
almost 2 years ago 4:17am 6 May 2023 - 🇦🇺Australia darvanen Sydney, Australia
Thanks for your work both to update the MR and review it.
However, the build in the MR was not built using the altered gulpfile. Please run
gulp build
after adjusting the pipeline ;) - last update
almost 2 years ago 14 pass - Status changed to Needs review
almost 2 years ago 7:37pm 7 May 2023 - 🇺🇸United States kevinfunk
@darvanen, sorry, I didn't check to make sure the js files were updated when I ran my tests. Everything should be good now.
- last update
almost 2 years ago 14 pass -
darvanen →
committed 3915a5ba on 4.x authored by
kevinfunk →
Issue #3358342 by kevinfunk, akshaydalvi212, darvanen: Remove global...
-
darvanen →
committed 3915a5ba on 4.x authored by
kevinfunk →
- Status changed to Fixed
almost 2 years ago 10:54pm 7 May 2023 - 🇦🇺Australia darvanen Sydney, Australia
All good, thanks for following up. Committed.
Automatically closed - issue fixed for 2 weeks with no activity.