- First commit to issue fork.
- @pavlosdan opened merge request.
-
pavlosdan →
committed 1d0905c6 on 8.x-1.x
Issue #3200895 by Nitesh Sethia, sergiur, PCate: Undefined index:...
-
pavlosdan →
committed 1d0905c6 on 8.x-1.x
- Status changed to Fixed
over 1 year ago 10:24pm 14 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 7:03pm 4 May 2023 - 🇺🇸United States pcate
@pavlosdan the release notes for 8.x-1.0-alpha5 → mention this issue's fix is included, but it doesn't appear to be.
- 🇨🇦Canada pavlosdan
https://git.drupalcode.org/project/paragraphs_limits/-/blob/8.x-1.0-alph...
The code from the patch is present in alpha5. Is the issue not resolved @PCate?
- 🇺🇸United States pcate
The code from the patch is present in alpha5.
That's not what I'm seeing, even in the code you linked to.
Line 28 should be
$selection_handler_settings = $this->configuration ?: [];
not
$selection_handler_settings = $this->configuration['handler_settings'] ?: [];
Looking at the dev branch the patch's changes are there: https://git.drupalcode.org/project/paragraphs_limits/-/commits/8.x-1.x
but aren't in the alpha5 tagged branch: https://git.drupalcode.org/project/paragraphs_limits/-/commits/8.x-1.0-a...
- 🇺🇸United States pcate
@pavlosdan, just following up on this. As you can see from the git commit graph: https://git.drupalcode.org/project/paragraphs_limits/-/network/8.x-1.0-a... the fix for this issue wasn't included in the alpha5 release.