Contrib.social

Site ID is not visible in settings form if set via environment variable

Open on Drupal.org →
Created on 29 April 2024, 7 months ago

Problem/Motivation

The site ID is not visible in settings form if set via environment variable

Steps to reproduce

Set site ID using the FASTLY_SITE_ID environment variable. The settings form has an empty site ID config field.

Proposed resolution

Show the ID and disable the form field.

Remaining tasks

Is this the right approach?

The API token is visible in the form when set via the environment, and it can be edited.

The service ID field id hidden when set via the environment. It cannot be seen in the form.

The three settings / environment variables should probably behave the same way.

User interface changes

The site ID field is disable if it is set using an environment variable.

API changes

None.

Data model changes

None.

✨ Feature request
Status

Active

Version

3.0

Component

Code

Created by

🇩🇰Denmark arnested

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @arnested
  • Status changed to Needs review 7 months ago
  • Comment 7 months ago →
    🇩🇰Denmark arnested
  • Status changed to RTBC 7 months ago
  • Comment 7 months ago →
    🇺🇦Ukraine rollins

    Changes from #2 work great, I think it makes sense to merge it

  • Comment about 2 months ago →
    🇺🇸United States inversed

    I think the main issue is that this would need the same type of warning message shown when the Service ID or API key are overridden.

    Warning message
    Site id is overridden in settings.php or with environment variable so it's not shown in the config form.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024