Account created on 19 April 2018, almost 7 years ago
#

Merge Requests

More

Recent comments

🇺🇦Ukraine rollins

I tested both of current version of gin (4.0.2 and 8.x-3.0)
Drupal core version 10.2.6
Single Content Sync 1.4.8

I was not able to reproduce this issue, action button and tabs looks good on general import page and on single node export page

🇺🇦Ukraine rollins

This issue is not only for taxonomy terms.
I am rendering commerce orders and have the same bug.
The pager does not appear on the layout builder page.
Drupal core 10.3.1

🇺🇦Ukraine rollins

rollins changed the visibility of the branch 3204517-add-primary-keys to active.

🇺🇦Ukraine rollins

Result of update commands:

[notice] Update started: activity_creator_update_8803
[error]  SQLSTATE[42000]: Syntax error or access violation: 1280 Incorrect index name 'ansid_tmp': ALTER TABLE "activity_notification_status" ADD PRIMARY KEY ("ansid"); Array

[error]  Update failed: activity_creator_update_8803
[notice] Update started: activity_send_update_8003
[error]  SQLSTATE[42000]: Syntax error or access violation: 1280 Incorrect index name 'uasid_tmp': ALTER TABLE "user_activity_send" ADD PRIMARY KEY ("uasid"); Array

[error]  Update failed: activity_send_update_8003
[notice] Update started: activity_send_email_update_8002
[error]  SQLSTATE[42000]: Syntax error or access violation: 1280 Incorrect index name 'uadid_tmp': ALTER TABLE "user_activity_digest" ADD PRIMARY KEY ("uadid"); Array

[error]  Update aborted by: activity_creator_update_8803, activity_send_update_8003, activity_send_email_update_8002
[error]  Finished performing updates.
🇺🇦Ukraine rollins

I have the same problem as @rlelie
social_core_update_111206 was not run after drush_updb on 12.4.2 version of open_social
so the error message still exists

🇺🇦Ukraine rollins

CKEditor 4 not supported: This project is no longer supported, and is no longer available for download. Uninstalling everything included by this project is strongly recommended.

🇺🇦Ukraine rollins

#11 resolved this bug, thank you!

🇺🇦Ukraine rollins

I can confirm that patch #25 resolved the bug
Thank you @rosk0

🇺🇦Ukraine rollins

I have the same issue
Nothing happened after that

🇺🇦Ukraine rollins

I created MR where a confirmation message before deleting added

🇺🇦Ukraine rollins

Changes from the MR make sense, it will allow using this module on Drupal 11x

🇺🇦Ukraine rollins

I faced the same problem with extra fields visibility
Change from the MR make sense

🇺🇦Ukraine rollins

I can confirm that changes from the MR make sense here
It will prevent us to have the fatal error

🇺🇦Ukraine rollins

I can confirm that links work correctly after MR

🇺🇦Ukraine rollins

I added a browser test to cover the main configuration form and export form

🇺🇦Ukraine rollins

Changes from the MR fixed Mini pager styles

🇺🇦Ukraine rollins

Changes from the MR look great to me also

🇺🇦Ukraine rollins

Patch that @yepa provided for the menu_item_extras resolved the issue for me
Thank you!

🇺🇦Ukraine rollins

I can also confirm that changes from the MR work well

🇺🇦Ukraine rollins

I using search api view with better_exposed_filters + Contextual filters (with 3 fixed arguments) + Ajax + Facets
and patch #3 the patch broke the search page
I do not know what the case of using this patch is, but I think it should be a much more specific code

for now, this code is very general

🇺🇦Ukraine rollins

I tested the code from MR and got the next error:
Fatal error: Type of Drupal\views\Form\ViewsExposedForm::$routeMatch must not be defined (as in class Drupal\Core\Form\FormBase) in /var/www/html/web/core/modules/views/src/Form/ViewsExposedForm.php on line 21

🇺🇦Ukraine rollins

Changes from MR resolved the issue with changing the "none" option to "Default"

🇺🇦Ukraine rollins

Changes from MR look great!
I think we need to merge this

🇺🇦Ukraine rollins

Changes from #2 work great, I think it makes sense to merge it

🇺🇦Ukraine rollins

MP provided by @mandclu fixed the warning message
I think this can be merged

🇺🇦Ukraine rollins

I tested this locally, and now the Twitter logo changed to the X
I think this can be merged

🇺🇦Ukraine rollins

It looks like MR has a merge error, also I think is better to use the ternary operator, to have fewer lines of code

🇺🇦Ukraine rollins

Changes from MR fixed warning message after upgrade to 1.0.4

🇺🇦Ukraine rollins

I can confirm that changes from MR make sense, without this we will always have error using this module

🇺🇦Ukraine rollins

Added new MR, this can be merged now

🇺🇦Ukraine rollins

rollins changed the visibility of the branch 3315948-replace-readme.txt-with to hidden.

🇺🇦Ukraine rollins

rollins made their first commit to this issue’s fork.

🇺🇦Ukraine rollins

Changes from MR look good to me, I think this can be merged

🇺🇦Ukraine rollins

Changes from MR resolved issue, thank you @claudiucristea

🇺🇦Ukraine rollins

Changes from @grevil look good, I think it can be merged

🇺🇦Ukraine rollins

Changes from #6 make sense here, and work as expected

🇺🇦Ukraine rollins

Changes from #23 look good, it can be merged

🇺🇦Ukraine rollins

rollins made their first commit to this issue’s fork.

🇺🇦Ukraine rollins

@Greg Boggs, maybe better to have one commit for this with better descriptions, what do you think?
I do not think that ‘fix the issue’ and ‘Removed patch file’ are good commit names for merging

🇺🇦Ukraine rollins

Drupal core 10.2.2 and group 2.2.2
#8 patch works

I used view on search api group index:
add Contextual filters by group id
click "Provide default value" and select type "Group IDs for logged in user"
and "Allow multiple values" to be true

also if it is required you can select Skip item access checks settings in views query options.

🇺🇦Ukraine rollins

@joseph.olstad, Merge Request already attached to this issue
https://git.drupalcode.org/project/facets/-/merge_requests/18
@borisson_ committed this on 2.0.x

🇺🇦Ukraine rollins

patches from guys resolved individual errors, but they did not resolve all cases
for example #17 patch resolves the bug with Ajax facets, but if the page includes a view text filter, it will show the same error as for facets

#19 patch resolves bug with view text filter, but does not handle with facets

so I merged these patches and created MR for it
This will handle all cases

note:
I was able to create MR only for 2.0.x version, there are no other options for now
so currently this MR can not be applied to check 2.0.6 version
I will attach the patch

🇺🇦Ukraine rollins

thank's @syammohanmp
The service that you provide works perfectly
I think we can close this issue because there are not any bugs or problems here

🇺🇦Ukraine rollins

I can confirm that MR #69 fixed the issue described in the Problem/Motivation section.
user_roles() and user_role_names() are deprecated in Drupal 10,
so I think we need to merge these changes

🇺🇦Ukraine rollins

I can confirm that Sourabhjain changes fixed the problem

🇺🇦Ukraine rollins

I took this issue and was able to reproduce it locally.
After applying changes from Serhii Morozov I was still not able to install mie_demo_base after uninstalling the module.
Also, I saw that the maintainer of the module changed the version of the module for this issue.
So I added changes to fix the issue.
Now we can install mie_demo_base after uninstalling the module, and changes can be merged to the last module version.

🇺🇦Ukraine rollins

I installed fresh Drupal 10 and field_limiter module
To the Basic page content type, I added a reference to the Article content type
Created 5 Articles (2 published and 3 unpublished)
Configured Limit for the reference field formatter to show 4 items
and it shows the correct 4 Article titles, including published and unpublished nodes
Tested several other cases, and every time module worked as expected

🇺🇦Ukraine rollins

I can confirm that path #2 works correctly
This fixed problems with lightning_workflow module on the Drupal 10
thanks

🇺🇦Ukraine rollins

The provided patch also working ok for me.
PHP 8.2
Drupal core 9.5.9

🇺🇦Ukraine rollins

I tested MR #2 from @sahal_va
and it also works for me
PHP 8.2
lightning_workflow module 3.19.0 version
Drupal core 9.5.9

🇺🇦Ukraine rollins

I can confirm that patch #2 resolved the bug.
thank's Harshita mehna!

🇺🇦Ukraine rollins

patch resolved the bug, now an anonymous user can see the website
I am using Drupal Core 9.5.9

🇺🇦Ukraine rollins

Patch #7 resolved bug for 9.5.7 core version.
thank you @iperiba92

🇺🇦Ukraine rollins

for those who cannot apply #2 patch
can try this one

🇺🇦Ukraine rollins

#2 patch works for me and it resolved the bug

Production build 0.71.5 2024