🇺🇦Ukraine @rollins

Changes look good

Just provided MR that will fix this bug

rollins → created an issue.

patch #35 resolved the issue for me, thanks!

I can also confirm that changes from the MR work well

I using search api view with better_exposed_filters + Contextual filters (with 3 fixed arguments) + Ajax + Facets
and patch #3 the patch broke the search page
I do not know what the case of using this patch is, but I think it should be a much more specific code

for now, this code is very general

I tested the code from MR and got the next error:
Fatal error: Type of Drupal\views\Form\ViewsExposedForm::$routeMatch must not be defined (as in class Drupal\Core\Form\FormBase) in /var/www/html/web/core/modules/views/src/Form/ViewsExposedForm.php on line 21

Changes from MR resolved the issue with changing the "none" option to "Default"

I can confirm that changes from MR fixed the warning message

Changes from MR look great!
I think we need to merge this

Changes from #2 work great, I think it makes sense to merge it

Changes from the #2 patch fixed the warning message

MP provided by @mandclu fixed the warning message
I think this can be merged

I tested this locally, and now the Twitter logo changed to the X
I think this can be merged

It looks like MR has a merge error, also I think is better to use the ternary operator, to have fewer lines of code

Changes from MR fixed warning message after upgrade to 1.0.4

I can confirm that changes from MR make sense, without this we will always have error using this module

Added new MR, this can be merged now

rollins → changed the visibility of the branch 3315948-replace-readme.txt-with to hidden.

rollins → made their first commit to this issue’s fork.

Changes from MR look good to me, I think this can be merged

Changes from MR resolved issue, thank you @claudiucristea

Changes from @grevil look good, I think it can be merged

Changes from MR look good, I think it can be merged

Changes from #6 make sense here, and work as expected

Changes from #23 look good, it can be merged

rollins → made their first commit to this issue’s fork.

@greg-boggs do we still need fixed MR here?

MR is ready

rollins → made their first commit to this issue’s fork.

@Greg Boggs, maybe better to have one commit for this with better descriptions, what do you think?
I do not think that ‘fix the issue’ and ‘Removed patch file’ are good commit names for merging

Attached MR with the fix for this bug

rollins → created an issue.

@greg-boggs I attached MR.

rollins → made their first commit to this issue’s fork.

Drupal core 10.2.2 and group 2.2.2
#8 patch works

I used view on search api group index:
add Contextual filters by group id
click "Provide default value" and select type "Group IDs for logged in user"
and "Allow multiple values" to be true

also if it is required you can select Skip item access checks settings in views query options.

@joseph.olstad, Merge Request already attached to this issue
https://git.drupalcode.org/project/facets/-/merge_requests/18
@borisson_ committed this on 2.0.x

patches from guys resolved individual errors, but they did not resolve all cases
for example #17 patch resolves the bug with Ajax facets, but if the page includes a view text filter, it will show the same error as for facets

#19 patch resolves bug with view text filter, but does not handle with facets

so I merged these patches and created MR for it
This will handle all cases

note:
I was able to create MR only for 2.0.x version, there are no other options for now
so currently this MR can not be applied to check 2.0.6 version
I will attach the patch

thank's @syammohanmp
The service that you provide works perfectly
I think we can close this issue because there are not any bugs or problems here

I can confirm that MR #69 fixed the issue described in the Problem/Motivation section.
user_roles() and user_role_names() are deprecated in Drupal 10,
so I think we need to merge these changes

I can confirm that Sourabhjain changes fixed the problem

I took this issue and was able to reproduce it locally.
After applying changes from Serhii Morozov I was still not able to install mie_demo_base after uninstalling the module.
Also, I saw that the maintainer of the module changed the version of the module for this issue.
So I added changes to fix the issue.
Now we can install mie_demo_base after uninstalling the module, and changes can be merged to the last module version.

rollins → made their first commit to this issue’s fork.

I installed fresh Drupal 10 and field_limiter module
To the Basic page content type, I added a reference to the Article content type
Created 5 Articles (2 published and 3 unpublished)
Configured Limit for the reference field formatter to show 4 items
and it shows the correct 4 Article titles, including published and unpublished nodes
Tested several other cases, and every time module worked as expected

I can confirm that path #2 works correctly
This fixed problems with lightning_workflow module on the Drupal 10
thanks

The provided patch also working ok for me.
PHP 8.2
Drupal core 9.5.9

I tested MR #2 from @sahal_va
and it also works for me
PHP 8.2
lightning_workflow module 3.19.0 version
Drupal core 9.5.9

I can confirm that patch #2 resolved the bug.
thank's Harshita mehna!

patch resolved the bug, now an anonymous user can see the website
I am using Drupal Core 9.5.9

Patch #7 resolved bug for 9.5.7 core version.
thank you @iperiba92

patch #2 solved the bug.
thank you @facine

Patch #28 resolved the issue, thank you DavorHorvacki!

for those who cannot apply #2 patch
can try this one

#2 patch works for me and it resolved the bug

Added patch to fix bug

rollins → created an issue.