- πͺπΈSpain javitan
#59 solves the issue for me using Drupal 9.5.5. I'm using a view with a contextual filter and I'm exposing the filters with Better Exposed Filters. Also the Media Library is working normally. Anyway, I removed an empty
if
. - last update
over 1 year ago 30,283 pass, 50 fail - last update
over 1 year ago 30,341 pass - Status changed to Needs review
10 months ago 2:33pm 19 March 2024 - Merge request !7092Issue #2821962: Views exposed filters don't combine with contextual filters when using exposed form in block β (Open) created by Liam Morland
- Status changed to Needs work
10 months ago 2:45pm 19 March 2024 The Needs Review Queue Bot β tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request β . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Needs review
10 months ago 3:14pm 19 March 2024 - Status changed to Needs work
10 months ago 3:39pm 19 March 2024 - πΊπΈUnited States smustgrave
There's no issue summary. Please use the standard issue template.
- Status changed to Needs review
10 months ago 4:42pm 19 March 2024 - π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Problem/Motivation
View exposed filters and contextual filters cannot be used together. The contextual filter is ignored when the exposed filters are used.
Steps to reproduce
Create a View with both exposed filters and contextual filters. Try to use the exposed filters.
Proposed resolution
Pass the existing contextual filter arguments to the View when exposed filters are used.
Remaining tasks
Finalize implementation.
User interface changes
None except that the filters will work as expected.
API changes
None.
Data model changes
None.
Release notes snippet
- Status changed to Needs work
9 months ago 2:41pm 24 March 2024 - πΊπΈUnited States smustgrave
Left some comments on MR.
Will need some test coverage to show the issue.
Hiding patches for clarity.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Thanks; changes in comments committed
- πΊπ¦Ukraine rollins
I tested the code from MR and got the next error:
Fatal error: Type of Drupal\views\Form\ViewsExposedForm::$routeMatch must not be defined (as in class Drupal\Core\Form\FormBase) in /var/www/html/web/core/modules/views/src/Form/ViewsExposedForm.php on line 21
- Status changed to Needs review
8 months ago 1:59pm 7 May 2024 - π¨π¦Canada Liam Morland Ontario, CA π¨π¦
I have removed using of constructor property promotion which should resolve the
$routeMatch
error. - Status changed to Needs work
8 months ago 2:07pm 9 May 2024 - πΊπΈUnited States smustgrave
Thanks for keeping this going
Was previously tagged for tests so moving back to NW for that.
Left a comment about using promotion that should simplify things.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
I removed the constructor property promotion because when it is used, the property has a type declared. That type doesn't match the parent and so you get the error shown in #74.
To avoid all this, I just updated the merge request to use
::getRouteMatch()
. - πΊπΈUnited States SocialNicheGuru
This was available for Drupal 7, https://www.drupal.org/project/filter_harmonizer β
- Status changed to RTBC
4 months ago 8:16am 3 September 2024 - π¬π·Greece vensires
The changes from the latest MR solved the problem for me. Thank you!
Setting it as RTBC. - Status changed to Needs work
4 months ago 8:33am 3 September 2024 - π³π±Netherlands Lendude Amsterdam
This still needs automated test coverage before it can be committed.
- π¬π·Greece vensires
In my latest change I allowed the inclusion of parameters with the
all
value.
Without this change, URLs like/foo/bar/[arg_0]/[arg_1]/[arg_2]
throw an exception if [arg_2] has a value but [arg_1] isall
.