PHP 8.2 deprecation issue with AutosaveFormBuilder

Reviewed the patch and tested it. Its working prefect. moving to RTCB.

vipin.mittal18 → made their first commit to this issue’s fork.

As PHP 8.2 test cases failed, the status was changed to the correct one.

The test failures are not the result of this patch. Tests are failing on the unpatched dev branch → already (and the released version of the module too).

The failures are different on the merge request because vipin.mittal18 added an absolutely necessary fix for the tests to run at all— changing the theme to Stark, rather than Classy which is not enabled. But that, and the general test failures, should probably be dealt with in a separate issue / patch.

The patch in stevenlafl's initial issue creation is correct and is ready to be committed as per keshav.k's review.

+1 on RTBC.

But this issue shouldn't be occurring after https://www.drupal.org/node/3292540 → or am I missing something here?

You would think, yes. Perhaps there is something else going on that still injects that? I didn't dig into why or what is setting that property, but in 10.1 and PHP 8.2, that property is still getting set on a regular basis, or basically every page. The warnings are quite noisy.

+1 RTBC. I have tested the patch with Drupal 10.0.5 it was working fine.

The provided patch also working ok for me.
PHP 8.2
Drupal core 9.5.9

The reviewed patch also works for me
php - 8.2
drupal - 10.2
auto_username - 1.3

3 x RTBC. Could this be implemented in a stable release, I wonder?

Any chance of a release to include this?

The issue is due to the decorated service.

  form_builder.autosave_form:
    public: false
    class: \Drupal\autosave_form\Form\AutosaveFormBuilder
    decorates: form_builder
    # The decorated autosave form builder should be the first applied as it
    # will not call further decorators, but directly override the core form
    # builder by extending from it and just calling the parent methods.
    decoration_priority: 10000
    arguments: ['@form_builder.autosave_form.inner', '@form_validator', '@form_submitter', '@form_cache', '@module_handler', '@event_dispatcher', '@request_stack', '@class_resolver', '@element_info', '@theme.manager', '@?csrf_token', '@autosave_form.entity_form_storage']
    # Workaround for serializing decorated services. Remove when either
    # https://www.drupal.org/project/drupal/issues/2896993 or
    # https://www.drupal.org/project/drupal/issues/2531564 are fixed.
    properties: { _serviceId: form_builder }

#2896993: Decorated services crash on serialization. → was fixed in 9.4.x, and #2531564: Fix leaky and brittle container serialization solution → in 9.5. We can remove the workaround and change core_version_requirement to core_version_requirement: ^9.5 || ^10

See https://www.drupal.org/project/autosave_form/issues/3355495 🐛 PHP 8.2 deprecation issue with AutosaveFormBuilder Needs work

PR #12 worked for me, no longer seeing the deprecation error.

Adding a patch file version of the merge request #12

https://git.drupalcode.org/project/autosave_form/-/merge_requests/12#not...

Necessary to be merged to let 📌 Automated Drupal 11 compatibility fixes for autosave_form Needs review happen also.

We're using this patch for quite some time now on a multitude of projects in production. Would be nice to see this land! RTBC+1

Merged. Thank you. This will be part of the 1.6 release.

Don't forget to close the other MR so it won't linger around. https://git.drupalcode.org/project/autosave_form/-/merge_requests/9

hchonov → closed merge request !9

Thanks for the remainder, @BramDriesen :)

Automatically closed - issue fixed for 2 weeks with no activity.