ResourceNotFoundException with ajax facets when site running in subfolder

I've changed the check to use a preg_replace ensuring the base_path() is at the start of the string (a bit safer than just the str_replace).

For version 2.0.6.

#17 fixes the issue for me also. I agree that ajax_query should not include the base path in the first place. But with 🐛 Facets with AJAX not working in most of situations Needs review not yet fixed, it's nice to have a minimal solution which does not interfere.

I'm not sure if this was caused by something specific to our multisite setup, #17 didn't work for us.

In our case, base_path() is coming through as '/uk/', and $path is an absolute URL including the host and scheme (https://site.example)

As such, $path does not start with /uk/, so the regex doesn't replace anything.

Uploading a new patch to handle as absolute URLs.

Patch 19 looks like it'll cover more use cases.

Patch #19 also fixed this issue for us for a website living on a subfolder.

Committed, thanks everyone.

patches from guys resolved individual errors, but they did not resolve all cases
for example #17 patch resolves the bug with Ajax facets, but if the page includes a view text filter, it will show the same error as for facets

#19 patch resolves bug with view text filter, but does not handle with facets

so I merged these patches and created MR for it
This will handle all cases

note:
I was able to create MR only for 2.0.x version, there are no other options for now
so currently this MR can not be applied to check 2.0.6 version
I will attach the patch

review for the latest patch (@rollins , please create a new Merge Request for this)

@joseph.olstad, Merge Request already attached to this issue
https://git.drupalcode.org/project/facets/-/merge_requests/18
@borisson_ committed this on 2.0.x

The MR looks good, it handles one more bug

+1

Added the patch for the MR!180 as it stands now to use in composer.

I created a new MR that includes all fixes, also I replaced str_contains with strpos,
because not all websites support this (str_contains only exists in php8)

Hard disagree. Please use str_contains instead. https://github.com/symfony/polyfill-php80 will ensure everyone can use this.

Safe to say we can rely on php8 +, php 7.4 is officially unsupported by Symfony based Drupals. This module is for D10/D11 not D8.
Therefore, I have no objection to the objection. With that said, I'm ok with strpos. I myself am hooked on strpos but str_contains is far easier to understand and reads better.

With that said, the pipeline is currently failing, would appreciate some assistance fixing that.