- Merge request !7Issue #3218880: Provide options to add Simple Sitemap files to robot.txt β (Open) created by gxleano
- π«π·France Adsyy
@gxleano, I think import of RequestStack should be "use Symfony\Component\HttpFoundation\RequestStack;" and not "use Drupal\Core\Http\RequestStack;"
Works for me after on D10 !
- πΊπ¦Ukraine Anna D
Anna D β made their first commit to this issueβs fork.
- last update
over 1 year ago 5 pass - πΊπ¦Ukraine Anna D
Agreed with #19. Replaced deprecated Drupal\Core\Http\RequestStack with Symfony\Component\HttpFoundation\RequestStack.
Tested with Drupal 10.1.5
- πͺπΈSpain gxleano CΓ‘ceres
Thanks @anna-d to take care of that, really appreciate it.
Would be great to have this feature on next releases @ccjjmartin.
- πΉπ·Turkey orkut murat yΔ±lmaz Istanbul
Sorry to bother, but can we merge this one too? :)
- π«π·France Grimreaper France π«π·
Hello,
Thanks for the work done here.
Rebasing the MR because there are merge conflicts.
- π«π·France Grimreaper France π«π·
MR rebased and CI fixed.
I have created another branch for rebase and to create a patch that will apply against 8.x-1.6.
- π«π·France Grimreaper France π«π·
Got the following warning:
Warning: foreach() argument must be of type array|object, null given in Drupal\Core\Render\Element\Checkboxes::valueCallback() (line 113 of core/lib/Drupal/Core/Render/Element/Checkboxes.php).
- Status changed to Needs review
21 days ago 6:00pm 1 May 2025 - First commit to issue fork.
- πΊπΈUnited States mcalabrese
When I first read this ticket I thought that the contents of the given simple_sitemap would be included as Allow statements in the robots.txt.
I misread the scope and thought that it included this ability.
Having said that, the current issue provides a lot of the functionality that I am looking for minus some code within the Controller.
I created a new branch to provide this additional functionality:
https://www.drupal.org/project/robotstxt/issues/3218880#:~:text=321880%2... β
branched off of:
https://www.drupal.org/project/robotstxt/issues/3218880#:~:text=3218880%... βPlease let me know if this functionality makes sense for this issue, if I need to create a new issue for this, or if it needs further work.
Thank you.