Cáceres
Account created on 9 October 2018, almost 6 years ago
#

Merge Requests

More

Recent comments

🇪🇸Spain gxleano Cáceres

Advanced settings have been moved from the field widget to the formatter settings on https://www.drupal.org/project/iconify_icons/releases/1.0.5 , so this issue can be closed as won't fix.

🇪🇸Spain gxleano Cáceres

Update documentation

🇪🇸Spain gxleano Cáceres

Update documentation

🇪🇸Spain gxleano Cáceres

It will be included in release 1.0.7

🇪🇸Spain gxleano Cáceres

It will be included in release 1.0.6

🇪🇸Spain gxleano Cáceres

Thanks Simon!

It will be included on release 1.2.21

🇪🇸Spain gxleano Cáceres

Add field formatter image

🇪🇸Spain gxleano Cáceres

Update images

🇪🇸Spain gxleano Cáceres

It will be included on release 1.2.20

🇪🇸Spain gxleano Cáceres

Thanks Alvaro!

It will be included on release 1.0.4

🇪🇸Spain gxleano Cáceres

Thanks Dieter!

It will be included on release 1.2.20

🇪🇸Spain gxleano Cáceres

Composer pipeline is failing because of Facets module latest version is not ready for Drupal 11 yet.

Moving to "Needs work".

🇪🇸Spain gxleano Cáceres

gxleano changed the visibility of the branch 3458978-select-widget-doesnt to active.

🇪🇸Spain gxleano Cáceres

gxleano changed the visibility of the branch 3458978-select-widget-doesnt to hidden.

🇪🇸Spain gxleano Cáceres

gxleano changed the visibility of the branch 3458978-select-widget-doesnt to hidden.

🇪🇸Spain gxleano Cáceres

Hi Dieter,

Could you provide more info, please?

I was not able to reproduce the reported issue.

Testing steps

Using a clean installation of latest version of Drupal (Claro by default) and Tagify:
1. Add a new entity reference field (Using taxonomy terms) and set Tagify Select as widget.
2. Create and Article, and the entity reference field using Tagify Select widget is working as expected.

Could you check if something that you have added to the project is interfering with the tags?

🇪🇸Spain gxleano Cáceres

It will be included on release 1.2.19

🇪🇸Spain gxleano Cáceres

Hi Dieter,

Thanks to take a look on this.

If we set the wait time to 50ms in the debounce function, it is making the tests fail.

See:

@param {number} wait
  The time period within which the callback function should only be
  invoked once. For example if the wait period is 250ms, then the callback
  will only be called at most 4 times per second.

I need to find some time to figure out how we can fix this in the best way.

🇪🇸Spain gxleano Cáceres

gxleano changed the visibility of the branch 3439417-fix-tagify-library to hidden.

🇪🇸Spain gxleano Cáceres

gxleano changed the visibility of the branch 3439417-use-internal-lib to hidden.

🇪🇸Spain gxleano Cáceres

gxleano changed the visibility of the branch 1.2.x to hidden.

🇪🇸Spain gxleano Cáceres

Thanks for the reply, now it is clearer.

Could you paste here the error that you are getting, please?

🇪🇸Spain gxleano Cáceres

BTW, #default_value should be an array of entities, you could check an example from the latest version here: https://www.drupal.org/project/tagify/issues/3411891#comment-15588899 Add support for custom form-element supporting entity_reference Needs review

🇪🇸Spain gxleano Cáceres

Hi Ok4p1,

We have updated Tagify form element in 1.2.18, see: https://www.drupal.org/project/tagify/issues/3411891 Add support for custom form-element supporting entity_reference Needs review

So, if you want to use the latest version, you might update your custom form elements.

🇪🇸Spain gxleano Cáceres

A new option has been added to the Iconify Icons widget settings.

You can now enable or disable the Advanced Iconify Icon Settings for additional customization options.

🇪🇸Spain gxleano Cáceres

gxleano made their first commit to this issue’s fork.

🇪🇸Spain gxleano Cáceres

It will be part of release 1.0.2

🇪🇸Spain gxleano Cáceres

It will be included on release 1.2.18

🇪🇸Spain gxleano Cáceres

Thanks Dieter,

I will include this fix into https://www.drupal.org/project/tagify/issues/3411891 Add support for custom form-element supporting entity_reference Needs review

🇪🇸Spain gxleano Cáceres

I don't really know if make sense to merge the modules, because of the are implemented from different perspectives.

Iconify Icons is designed to be a lightweight module that requires no external library downloads. It works seamlessly with Iconify API calls and is fully Drupal-oriented, even for the Icon Picker feature.

As detailed in this issue, Iconify Icons aims to be a comprehensive and ambitious integration that includes a wide range of features.

However, as mentioned in previous comments, we are open to collaboration on any necessary aspects. This is an offer we made at the time.

🇪🇸Spain gxleano Cáceres

Hi @delacosta456!

Currently, our primary focus is on maximizing performance. Although the icon picker is on our roadmap and will be available as a submodule for users who need it or find it convenient, it has not been a priority to date. Improving performance will also facilitate the development of the icon picker.

Thanks for your kind words.

🇪🇸Spain gxleano Cáceres

It will be part of release 1.0.1

🇪🇸Spain gxleano Cáceres

Thanks @jwilson3 for the report!

I also fix a bug related with the link on this issue.

It will be part of release 1.0.1

🇪🇸Spain gxleano Cáceres

gxleano made their first commit to this issue’s fork.

🇪🇸Spain gxleano Cáceres

I've found the problem, seems like this is related with the wait time in the Drupal.debounce.

@param {number} wait
  The time period within which the callback function should only be
  invoked once. For example if the wait period is 250ms, then the callback
  will only be called at most 4 times per second.

We removed the wait parameter from the input in 1.2.12

🇪🇸Spain gxleano Cáceres

I've been checking between versions and 1.2.11 doesn't have the "bug", so the "bug" was definitely introduced here: https://www.drupal.org/project/tagify/releases/1.2.12 , but I need some time to debug it in depth.

🇪🇸Spain gxleano Cáceres

On Firefox with the Gin theme, the AbortError occurs every time I type at a normal speed—not too fast, not too slow.

On Chrome is more difficult to reproduce it, but it is also reproducible using Claro as default theme.

In both cases, the suggestion dropdown correctly shows all relevant content without any issues.

See evidences:

Claro - Chrome

Gin - Firefox

🇪🇸Spain gxleano Cáceres

gxleano made their first commit to this issue’s fork.

🇪🇸Spain gxleano Cáceres

Hi Dieter,

I've been testing the issue, and everything works fine on my end. The browser console shows the AbortError when a request is aborted (e.g., when the input value doesn't match any suggestion and it has been typed quickly), but this error does not affect the behavior of the Tagify element.

I will test this more carefully, but it should not be a big issue.

Production build 0.71.5 2024