Review steps
- Install
Drupal 11.x
. - Enable Navigation module.
- Check menus and inspect the html for them.
See evidences:
Content Menu
Administration Menu
Help Menu
Everything works as expected ✅
Moving to RTBC.
gxleano → created an issue. See original summary → .
Test added and passing.
Thanks for review @plopesc!!
Moving to RTBC.
gxleano → made their first commit to this issue’s fork.
Review steps
- Install
Drupal 11.x
- Enable Navigation module
- Run
drush updb
See evidences:
Update database
New user navigation link
Everything works as expected ✅
Moving to RTBC.
Review steps
- Install a Vanilla Drupal site (
Drupal 11.x
) and Enable Navigation Top Bar module - Create node and visit the node page
- Confirm that page actions dropdown is there and the "Edit" options is NOT visible when expanded
See evidences:
Review steps
1. Install Umami demo site.
2. Enable navigation
module.
3. Check Umami message on new navigation.
Everything works as expected, see the screenshot below:
Expanded:
Collapsed:
Collapsed with tooltip:
I've fixed the tests and reviewed and everything works fine on my end.
Moving this issue to Closed (duplicate) and added related issue.
Moving this issue to Colsed (duplicate) and added the related issue.
It will be included in release 1.2.31
Thanks @stmh to report this bug and @solimanharkas to take care of it.
I've been testing and everything works as expected.
Great job!
I've been testing the MR and it's working as expecting.
It will be included in 1.2.31
release.
Understood, I will take a look into your changes.
Thanks!
In my view, there are two distinct aspects here:
Bug Fix: The issue of matching results not appearing when a label is modified. This has been addressed in the current update. It appears that the label alteration feature wasn't functioning as expected, and the new logic now resolves this issue.
New Feature: The addition of alternative spellings or synonyms configuration for the Tagify widget. We can introduce a new configuration option in the widget that allows you to define alternative spellings or synonyms using tokens and specify the field that contains these variations.
So, I would create a new issue where add the requirements about the new feature.
Thanks for the review Dieter!
It will be included in 1.2.30
release.
The same logic will be added to the Tagify User List module.
The main issue was the 'no matching item' message which was appearing immediately after typing, even when a match existed. This was caused by the lack of debounce on the dropdownItemNoMatch
function, which resulted in an early feedback. To fix this, I've wrapped dropdownItemNoMatch
in a debounce, ensuring smoother performance and preventing the message from displaying unnecessarily.
Thanks Dieter for the quick feedback!
Thanks Oleksandr for the fix!
It will be included in release 1.2.29
It is working as expected.
Thank you very much @oleksandr.s to report and fix this bug.
It will be included in release 1.2.29
penyaskito → credited gxleano → .
It will be included in release 1.0.13
It will be included on release 1.2.28
It works as expected, thanks Dieter!
It will be added to release 1.2.28
It will be included on release 1.0.13
gxleano → created an issue.
gxleano → created an issue.
After applying the change, everything looks better.
See:
It will be included on release 1.0.12
It will be included on release 1.2.27
It will be included on release 1.2.27
It will be included on release 1.2.27
Closing this issue because of it has been more than 2 month without activity and it can't be reproduced.
It will be included on release 1.2.27