Cáceres
Account created on 9 October 2018, over 6 years ago
#

Merge Requests

More

Recent comments

🇪🇸Spain gxleano Cáceres

Review steps

  1. Install Drupal 11.x.
  2. Enable Navigation module.
  3. Check menus and inspect the html for them.

See evidences:

Content Menu

Administration Menu

Help Menu

Everything works as expected ✅

Moving to RTBC.

🇪🇸Spain gxleano Cáceres

Test added and passing.

Thanks for review @plopesc!!

Moving to RTBC.

🇪🇸Spain gxleano Cáceres

Review steps

  1. Install Drupal 11.x
  2. Enable Navigation module
  3. Run drush updb

See evidences:

Update database

New user navigation link

Everything works as expected ✅

Moving to RTBC.

🇪🇸Spain gxleano Cáceres

Review steps

  1. Install a Vanilla Drupal site (Drupal 11.x) and Enable Navigation Top Bar module
  2. Create node and visit the node page
  3. Confirm that page actions dropdown is there and the "Edit" options is NOT visible when expanded

See evidences:

🇪🇸Spain gxleano Cáceres

Review steps

1. Install Umami demo site.
2. Enable navigation module.
3. Check Umami message on new navigation.

Everything works as expected, see the screenshot below:

Expanded:

Collapsed:

Collapsed with tooltip:

🇪🇸Spain gxleano Cáceres

I've fixed the tests and reviewed and everything works fine on my end.

🇪🇸Spain gxleano Cáceres

gxleano changed the visibility of the branch 8.x-1.x to hidden.

🇪🇸Spain gxleano Cáceres

Moving this issue to Colsed (duplicate) and added the related issue.

🇪🇸Spain gxleano Cáceres

Thanks @stmh to report this bug and @solimanharkas to take care of it.

I've been testing and everything works as expected.

Great job!

🇪🇸Spain gxleano Cáceres

I've been testing the MR and it's working as expecting.

It will be included in 1.2.31 release.

🇪🇸Spain gxleano Cáceres

Understood, I will take a look into your changes.

Thanks!

🇪🇸Spain gxleano Cáceres

In my view, there are two distinct aspects here:

Bug Fix: The issue of matching results not appearing when a label is modified. This has been addressed in the current update. It appears that the label alteration feature wasn't functioning as expected, and the new logic now resolves this issue.

New Feature: The addition of alternative spellings or synonyms configuration for the Tagify widget. We can introduce a new configuration option in the widget that allows you to define alternative spellings or synonyms using tokens and specify the field that contains these variations.

So, I would create a new issue where add the requirements about the new feature.

🇪🇸Spain gxleano Cáceres

Thanks for the review Dieter!

It will be included in 1.2.30 release.

🇪🇸Spain gxleano Cáceres

The same logic will be added to the Tagify User List module.

🇪🇸Spain gxleano Cáceres

gxleano made their first commit to this issue’s fork.

🇪🇸Spain gxleano Cáceres

The main issue was the 'no matching item' message which was appearing immediately after typing, even when a match existed. This was caused by the lack of debounce on the dropdownItemNoMatch function, which resulted in an early feedback. To fix this, I've wrapped dropdownItemNoMatch in a debounce, ensuring smoother performance and preventing the message from displaying unnecessarily.

🇪🇸Spain gxleano Cáceres

Thanks Dieter for the quick feedback!

🇪🇸Spain gxleano Cáceres

Thanks Oleksandr for the fix!

It will be included in release 1.2.29

🇪🇸Spain gxleano Cáceres

It is working as expected.

Thank you very much @oleksandr.s to report and fix this bug.

It will be included in release 1.2.29

🇪🇸Spain gxleano Cáceres

It will be included in release 1.0.13

🇪🇸Spain gxleano Cáceres

It will be added to release 1.2.28

🇪🇸Spain gxleano Cáceres

After applying the change, everything looks better.

See:

🇪🇸Spain gxleano Cáceres

It will be included on release 1.0.12

🇪🇸Spain gxleano Cáceres

Add Tagify Icons documentation

🇪🇸Spain gxleano Cáceres

It will be included on release 1.2.27

🇪🇸Spain gxleano Cáceres

It will be included on release 1.2.27

🇪🇸Spain gxleano Cáceres

It will be included on release 1.2.27

🇪🇸Spain gxleano Cáceres

Closing this issue because of it has been more than 2 month without activity and it can't be reproduced.

🇪🇸Spain gxleano Cáceres

It will be included on release 1.2.27

Production build 0.71.5 2024