Cáceres
Account created on 9 October 2018, almost 7 years ago
#

Merge Requests

More

Recent comments

🇪🇸Spain gxleano Cáceres

Thank you very much Dieter and Christian for your effort here.

It will be included in the next release 1.2.42

🇪🇸Spain gxleano Cáceres

Thanks to report this issue @damienmckenna

I've been testing it with next configuration:

Drupal 11.2.2
AI Core 1.1.x
AI Search 1.1.x
AI Assistant Api 1.1.x
AI Agents 1.1.x
Huggingface Provider 1.0.x
Sqlite Provider 1.0.x
Search API 1.38

From Huggingface provider I have used the next models:
Chat -> Meta Llama-3-8B
Embeddings -> MxBai Embed Large v1

And I have needed to apply the next patch in Search API in order to can create the view:
https://www.drupal.org/project/search_api/issues/3531256 🐛 Cannot create Search API based views On Drupal 11 Active

I was NOT able to reproduce the error that you are describing. Maybe the problem could be the fields that you are using in Search API Index, and the filter criteria added to the view.

I am using the next fields in Search API Index:
- rendered_item with type fulltext and main content as indexing option
- url with type string and Contextual content as indexing option
- title with type fulltext and contextual content as indexing option

Then in the view I am adding Fulltext search as filter criteria, then when I perform a search query everything works as expected.

Moving this issue to Postponed until we get more info about the issue in your side.

🇪🇸Spain gxleano Cáceres

gxleano changed the visibility of the branch 3487487-improve-ai-search-table to hidden.

🇪🇸Spain gxleano Cáceres

gxleano changed the visibility of the branch 3487487-improve-ai-search-table to hidden.

🇪🇸Spain gxleano Cáceres

Thanks Scott to take a look on this!

Regarding #27 📌 Improve AI Search Module Indexing to Handle Long-Running Chunk Embedding Processes Needs work , we're currently displaying the item being indexed and the chunks being processed from that item. We're also showing the progress percentage for both. From my perspective, this provides clear and continuous feedback to the user about where we are in the process, which I believe is quite helpful.

Do you have any specific suggestions for improvement?

🇪🇸Spain gxleano Cáceres

Thinking twice, the Tagify Select widget is also able to drag and sort the tags when the field is unlimited, so this information should be there to let the user knows about this functionality.

I will try to think in a better way to can just get rid of this if you don't want it there, but from now I will keep it.

🇪🇸Spain gxleano Cáceres

Thanks @harlor for the fix.

It will be included in release 1.2.41

🇪🇸Spain gxleano Cáceres

gxleano made their first commit to this issue’s fork.

🇪🇸Spain gxleano Cáceres

Thanks to open this discussion @yaqbick

You're absolutely right, the description shouldn't appear in the Tagify Select widget.

However, it's intentionally included in the Tagify widget to inform users that they can drag and sort the element. This is important for UX purposes.

🇪🇸Spain gxleano Cáceres

Thanks @chr.fritsch for the contribution.

It would be added into the next release 1.2.41

🇪🇸Spain gxleano Cáceres

gxleano made their first commit to this issue’s fork.

🇪🇸Spain gxleano Cáceres

Thanks @volkerk for the contribution!

It will be added to release 1.2.41

🇪🇸Spain gxleano Cáceres

Thanks for review Artem!

As far as I was able to see, the chat() method in this case could just be taken from base class, I do not see any specific logic in the OpenAI provider.

What do you think Marcus?

🇪🇸Spain gxleano Cáceres

Thanks Artem to take a look on this!

If it doesn't have specific logic, them I would say that we can just remove it and take the logic form base class.

🇪🇸Spain gxleano Cáceres

gxleano made their first commit to this issue’s fork.

🇪🇸Spain gxleano Cáceres

BTW, the latest changes look good to me @pmelab.

Just waiting until branch 1.2.x is created, then we can move it to RTBC.

🇪🇸Spain gxleano Cáceres

Yes, in order to avoid breaking changes, we should create 1.2.x branch, then just point the changes on this MR to there.

🇪🇸Spain gxleano Cáceres

This issue should be tested with MR https://www.drupal.org/project/ai/issues/3526390 Improve the AI Search recursive retrieval of a specific quantity of results Active , from where some new methods are coming.

🇪🇸Spain gxleano Cáceres

Changes include the logic to handle the limitations of recursive vector search in scenarios involving:

  • Large content split into many small chunks
  • Numerous access-controlled nodes
  • Insufficient retrieval due to 10-iteration (maxAccessRetries) cap

At the meantime, I've also added related changes in https://www.drupal.org/project/ai_vdb_provider_milvus/issues/3526393 Make use of Milvus' Grouping functionality Active .

🇪🇸Spain gxleano Cáceres

It should be tested/reviewed after changes from https://www.drupal.org/project/ai/issues/3532517 📌 Remove AiDataTypeConverterPluginManager from Base class and load via trait Active are added to 1.2.x, then we would need to update this issue with 1.2.x

🇪🇸Spain gxleano Cáceres

After adding latest change related with RagTool, everything works fine from my side.

🇪🇸Spain gxleano Cáceres

In the meantime, I'm testing the recent changes, but previous updates to RagTool are breaking my testing scenario.

Previously, everything was working fine with the default Umami version. After searching for an existing recipe, it correctly returned the expected content. However, after applying the latest changes included in version 1.2.x, RagTool can no longer return any results when performing a search. Instead, it simply reports that no matches were found.

If we test with RagTool code coming from 1.1.x, everything works as expected.

🇪🇸Spain gxleano Cáceres

It will be included in the next release 1.2.41

🇪🇸Spain gxleano Cáceres

Thanks @lazzyvn!

I've added an extra validation to avoid Undefined array key "fieldDefinition" error.

Strange that no body report this issue before...I think that maybe it is related with some specific configurations.

🇪🇸Spain gxleano Cáceres

gxleano made their first commit to this issue’s fork.

🇪🇸Spain gxleano Cáceres

Thanks @bobooon for report and fix.

The fix will be included in the next release 1.2.41

🇪🇸Spain gxleano Cáceres

Thanks @huzooka and @idimopoulos to work and review it.

The fix will be included in release 1.2.41

🇪🇸Spain gxleano Cáceres

Then let's wait until Dan review and test it.

Thanks to check it Marcus.

🇪🇸Spain gxleano Cáceres

Another addition would be to have a link at the top like "Try it", "Try Drupal AI" or something pointing to https://www.drupalforge.org/template/drupal-cms-ai-demo, where users can "easily" test the Drupal AI features.

Production build 0.71.5 2024