We're trying to use Tagify on an entity form which was converted to a multi-step form (with Simple Multi Step Form → ). This form has two "steps", first one reveals all the entity fields the users have to fill in, and the second step is only a confirmation.
When the first step is submitted, the widget seems to work properly, the EntityAutocompleteTagify returns the right field value. But, when the second (last) step is also submitted, the calculated value will be wrong
EntityAutocompleteTagify::valueCallback() will go into the body of the first condition (because $input will be FALSE).#default_value will already contain all the preexisting and the new entities.EntityAutocompleteTagify::getTagifyDefaultValue does not handle new entities the right way. I checked how core's EntityAutocomplete does this and if the entity is new, then it returns the label of the entity at the value key.
Anyway, we're getting storage exception because (core's) EntityReferenceItem tries to create the term without label.
I am not convinced that this is really a Tagify issue, I'm just filing this ticket here because core's entity autocomplete widget does not have this problem.
Active
1.2
Code
Works as expected, resolved the issue. And the fix is minor and straight. RTBC+1
Thanks @huzooka and @idimopoulos to work and review it.
The fix will be included in release 1.2.41
Automatically closed - issue fixed for 2 weeks with no activity.