- Issue created by @marcus_johansson
- First commit to issue fork.
- Merge request !38Issue #3528590: Add hook_update_N() to set default model if it is not set to... โ (Merged) created by gxleano
- ๐ฉ๐ชGermany marcus_johansson
The CI failing is because of an update in Drupal CI, I fixed it here ๐ grumphp.yml Forbidden word (blacklist) Active . Just merge with 1.1.x and it will be fixed.
I have added a comment and suggestion. If you take my code, please test it, it was written freehand in gitlab.
- ๐ช๐ธSpain gxleano Cรกceres
// If its set, we just return false. if (!empty($default_providers[$operation_type])) { return FALSE; }
This piece of code is not doing what we are expecting, right now it is detecting
$default_providers[$operation_type]
as not empty even when themodel_id
is not selected, we should check:// If its set, we just return false. if (!empty($default_providers[$operation_type]['model_id'])) { return FALSE; }
Because the
provider_id
will be always there, see: - ๐ช๐ธSpain gxleano Cรกceres
Or maybe we should specify that we should only update it if the default provider is not selected.
-
marcus_johansson โ
committed e26ea5bb on 1.1.x authored by
gxleano โ
Issue #3528590: Add hook_update_N() to set default model if it is not...
-
marcus_johansson โ
committed e26ea5bb on 1.1.x authored by
gxleano โ
Automatically closed - issue fixed for 2 weeks with no activity.