Currently, AmazeeAI provider is implemented using the OpenAI SDK directly, with only minor variations.
This approach has led to significant code duplication (reused by other providers), especially evident when implementing new features like function calling. In such cases, nearly identical logic had to be added in multiple places, making the codebase harder to maintain, test, and evolve.
To address this, we already have an AiProviderClientBase class as a common foundation. The proposed direction is to introduce an OpenAiBasedProviderClientBase as an intermediate abstract layer that encapsulates shared OpenAI-specific logic (e.g., request formatting, operation types, basic behavior), reducing duplication and simplifying future enhancements.
Refactoring existing OpenAI-based clients to extend from this new base class will eliminate redundant code, improve maintainability, and align these implementations with the Drupal AI core module's architecture—paving the way for better standardisation and extensibility across AI providers.
Active
1.1
Code
I fixed the MR. Could you give my changes another review?
Yes, in order to avoid breaking changes, we should create 1.2.x branch, then just point the changes on this MR to there.
BTW, the latest changes look good to me @pmelab.
Just waiting until branch 1.2.x is created, then we can move it to RTBC.
Automatically closed - issue fixed for 2 weeks with no activity.