- Issue created by @marcus_johansson
- First commit to issue fork.
- 🇪🇸Spain gxleano Cáceres
Once this issue is ready to go, we would need to also create follow up tickets on every provider in order to clean up the
openai-php/client
library from them. - 🇩🇪Germany marcus_johansson
Great work - I added some comments. The one about api key being optional needs to be fixed, look at the other and see if you agree. The streamed message could be a follow up issue, if needed.
- First commit to issue fork.
- 🇩🇪Germany marcus_johansson
Lookgs good for me - one comment - Dan will have a look as well, since the Amazee are dependent on it.
- 🇪🇸Spain gxleano Cáceres
Then let's wait until Dan review and test it.
Thanks to check it Marcus.
- 🇩🇪Germany marcus_johansson
Looks great now - I'll set this in RTBC and merge tomorrow if Dan didn't have a look. I think this might be one of the issues where its easier to continue developing and finiding missing scope/bugs by having it already in 1.2.x-dev, so you can target that with the providers under development.
The upgrade path to this should be safe - the providers can't be updated without 1.2.0 of the AI module, and updating the AI module to 1.2.0, but keeping 1.1.0 providers is fine.
- 🇨🇭Switzerland dan2k3k4 Zurich
We've provided changes to the other issue / MR - https://www.drupal.org/node/3532631 →
https://git.drupalcode.org/project/ai_provider_amazeeio/-/merge_requests/15So this MR should be good from our side.
- 🇩🇪Germany marcus_johansson
No one complained in the AI Contrib meeting, so in it goes.
-
marcus_johansson →
committed 6bdb6567 on 1.2.x authored by
gxleano →
Resolve #3531134 "Create base class"
-
marcus_johansson →
committed 6bdb6567 on 1.2.x authored by
gxleano →