Add a variable to specify phpstan level

+1

This is great. I'd love to see a test with a project using this fork and setting the level before committing it. Code wise looks good.

Changes from the MR look great to me also

I'd love to see a test with a project using this fork and setting the level before committing it

Before setting to RTBC, we need to see a project using this feature to make sure that there is no unexpected error or warning.

You can follow this https://project.pages.drupalcode.org/gitlab_templates/info/testing-mrs/ to test it in any other project that has GitLab CI enabled. Reverting back to Needs review.

@fjgarlin beat me to it :-)

I have successfully tested this with the ECA module by creating a branch with a tailored CI configuration: https://git.drupalcode.org/project/eca/-/blob/ci-test-3453102/.gitlab-ci...

For the first test, the variable _PHPSTAN_LEVEL was not set and there it used level 6 as configured in the phpstan.neon file. The jobs succeeds without any error, see https://git.drupalcode.org/project/eca/-/jobs/1845652

For the second test, the variable is set to level 7 in the gitlab ci file of the project and that fails as expected, see https://git.drupalcode.org/project/eca/-/jobs/1845701

Settings this to RTBC, as it works as expected.

Thanks for the test! Merged.

I'd like to add a few minor changes to this, specifically to display the level used, and expand the description to give the default.

Go for it. Feel free to create an additional MR and we can add it.

Changes look good. It only adds an echo so don't think this needs much testing.

MR222 ready for review, but BramDriesen has already done that [posts overlapped].

Example test https://git.drupalcode.org/project/scheduler/-/jobs/1852835

I also noticed that the phpstan doc page needs some updates. But I will add that to #3439644: Review all documentation pages → instead.

MR still looks ok with that last commit!

MR was merged. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.