- Issue created by @chaitanyadessai
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 2:21pm 21 March 2024 - last update
about 1 year ago Checkout Error - Assigned to Grevil
- Status changed to Needs work
about 1 year ago 8:47am 9 April 2024 - 🇩🇪Germany Anybody Porta Westfalica
Please finally check the module with phpcs and phpcbf. Guess the patch is outdated.
- 🇩🇪Germany Grevil
No @var declaration and incorrect description for injected services, random ";" added to the code and not all services were injected here. Sorry, but I can't give credit to that.
- 🇩🇪Germany Grevil
Ok, all phpcs are fixed, I just started to fix the remaining phpstan issues, also added a comment, which should be resolved first.
I will continue with fixing the remaining phpstan issues, stylelint issues and eslint issues on monday (maybe also the cspell issues, if they are quite easy to fix).
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 8:48am 15 April 2024 - 🇩🇪Germany Grevil
Alright, all done! The remaining issues are related to "css/builder.min.css" and the "gulpfile.js".
- Status changed to Needs work
about 1 year ago 8:49am 15 April 2024 - Status changed to Needs review
about 1 year ago 9:13am 15 April 2024 - 🇩🇪Germany Grevil
Alright, all done! Changes are correct now and nothing seems to be broken!
- Status changed to RTBC
about 1 year ago 11:13am 15 April 2024 - 🇺🇦Ukraine rollins
Changes from @grevil look good, I think it can be merged
-
Anybody →
committed 212eee2b on 3.0.x authored by
chaitanyadessai →
Issue #3432743 by Grevil: Use dependency injection and code style issues
-
Anybody →
committed 212eee2b on 3.0.x authored by
chaitanyadessai →
- Status changed to Fixed
about 1 year ago 1:51pm 16 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.