- Issue created by @vinodhinisureshbabu
- Issue was unassigned.
- Status changed to Needs review
8 months ago 6:28am 3 April 2024 - last update
8 months ago 6 pass - 🇺🇸United States Greg Boggs Portland Oregon
Thanks for the fix. Generally, we use array_key_exists to check to see if the key exists.
Also, please open merge requests and not patches for code you want to include.
- Status changed to Needs work
8 months ago 6:37am 3 April 2024 - Assigned to abhishek_virasat
- last update
8 months ago 6 pass - 🇮🇳India abhishek_virasat
abhishek_gupta1 → changed the visibility of the branch 3435864-Undefined-array-key-2 to hidden.
- 🇺🇸United States Greg Boggs Portland Oregon
The code looks perfect! I'd merge it, but it looks like the patch file is also in the MR, and we don't want the patch file to end up in the final module.
- last update
8 months ago 6 pass - 🇮🇳India abhishek_virasat
@Greg Boggs, yes by mistake patch file is uploaded. now check the new MR.
- Issue was unassigned.
- Status changed to Needs review
8 months ago 7:34am 3 April 2024 - 🇺🇦Ukraine rollins
@Greg Boggs, maybe better to have one commit for this with better descriptions, what do you think?
I do not think that ‘fix the issue’ and ‘Removed patch file’ are good commit names for merging - 🇩🇪Germany spuky
lets wait for 3415146 the try catch in there should fix the warning if not the merge request will need to be addapted to the changes there.
- Status changed to Needs work
5 months ago 6:54pm 26 June 2024 - 🇩🇪Germany spuky
Setting to needs work please check if the problem still exists if yes we need an updated merge request.
- 🇮🇳India samit.310@gmail.com
samit.310@gmail.com → made their first commit to this issue’s fork.
- Status changed to Needs review
5 months ago 8:10am 5 July 2024 -
spuky →
committed 647fce1b on 2.x authored by
samit.310@gmail.com →
Issue #3435864 by abhishek_gupta1, vinodhinisureshbabu, samit.310@gmail....
-
spuky →
committed 647fce1b on 2.x authored by
samit.310@gmail.com →
- Status changed to Fixed
5 months ago 8:54am 8 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.