🇩🇰Denmark @arnested

Oh. This only happens when I select the “Plugin reference” field type. If I select the “Filter” field type, it works.

What is the difference? I wasn't expecting to use a type named “Filter”. Reading the description made me try, though.

arnested → created an issue.

GH79382498HG

Nice. I was looking for exactly this today!

I have tested the code together with Drupal 10.3 and can confirm it works.

Since I wanted to have the benefit of this right away, I took the liberty and made it a small module: https://www.drupal.org/project/autowire_plugin_trait →

arnested → changed the visibility of the branch 3452916-get_class-is-deprecated to hidden.

arnested → created an issue.

arnested → created an issue.

arnested → created an issue.

This is a good and useful improvement.

I have tested the code in our environments and reviewed the patch. All good!

arnested → created an issue.

Released as 2.0.4 → .

Thank you for the kind words, @webmestre → .

The module just exposes PHP's NumberFormatter as a Drupal FieldFormatter. So all the heavy lifting is done by PHP itself.

And I think the module only supports a fraction of what PHP's NumberFormat is capable of. More or less the fractions I have had a use case for. :)

You are right, @adityarawat_ln → .

The currency must be a 3-letter ISO 4217 currency code.

I'll add description to the field to explain this. And maybe some validation if I can find an easy way to do this.

arnested → made their first commit to this issue’s fork.

arnested → made their first commit to this issue’s fork.

Thank you, larowlan → . 🎉

Searching for how to set a timeout, I came across this issue.

The issue is 5 years old, and I think is now outdated.

We're on Migrate Plus version 6.0.1, and we can set request options for the HTTP data fetcher plugins Guzzle like this:

source:
  plugin: url
  data_fetcher_plugin: http
  data_parser_plugin: json
  urls:
    - 'https://example.com/api/something'
  request_options:
    timeout: 120

I'm setting the issue status to “Closed (outdated)”. Please don't hesitate to reopen if I'm wrong / misunderstanding something.

Greetings from DrupalCon Lille 2023!

I have rebased the merge request in 11.x.

All tests are still green.

I'm not sure whether I'm allowed to put the status back to Reviewed & tested by the community myself. So I'm putting on Needs review instead.

Just that we should list in the info file.

I just did that and released it as 2.0.1 → .

Merged. Thank you, everyone.

arnested → made their first commit to this issue’s fork.

The base path only has a non-empty value if you install Drupal in a sub-folder.

That is the the difference between where the Drupal root/index.php is located: https://example.com vs https://example.com/here/is/drupal

Ok, took a stab at it now. Tests work on my machine now, but it's way past my bedtime, so I'll have to wait until tomorrow morning to see if Drupal CI agrees, and I can put it into Needs review again.

Thank you once again for the valuable feedback, @larowlan → .

Ah, now I understand, @larowlan → . I misread your remark regarding base path as just the path... Don't why. Re-reading it now, and it's quite obvious what you meant. I'll look into it. It might some days before I can find the time for it, though.

Thank you for the hints, @smustgrave → and @FeyP!

I managed to create a working test case for this now. I couldn't have done it without you!

I have added a test case with a trailing slash on the hostname, @larowlan → .

Thank you for your feedback @larowlan → .

You are quite right. We need to preg_quote the base path as well.

I went even further and also added preq_quote to the port. Although we would expect a number, Request::getPort() could return a string (we would still expect the string to hold a number, but this issue was created based on weird input, so I think it is better to be safe).

I added a test using a path with "weird" characters to make sure the quoting is in place.

Updated issue summary.

Fixed failing test case.

• Added an issue branch / merge request.
• Updated the issue summary.

Created an issue fork.

The one error is because of the change to default.settings.-php which makes CI fail on comparing it to duplicated default.settings.-php in Scaffold. See #3075954 📌 Remove duplicate scaffold files Needs work .

Nowadays, I think it's better to use a language server (LSP) than GNU Global. GNU Global served me well for many years, but today I'm only using language serves.

Rerolled for 10.1.x and improved comments a bit.

Thank you for providing feedback. That sounds like a very nice initiative.

I have extended the description with a bit more info on what the patch does (basically just hardening a regular expression and adding more test data covering the discovered edge cases).

I also made sure the patch still applies cleanly to the 10.1.x branch, and has just scheduled a new test run against 10.1.x as well.

I have attached a patch that declares the missing properties.

arnested → created an issue.