🇩🇰Denmark @arnested

Example with an event starting on March 30 and ending on April 6:

arnested → created an issue.

I think this is more complex than we have here. If we just set it in Drupal settings then if someone runs optimize on the db server it will change back again...

Not really.

Setting the row format in Drupal doesn't alter the database's default row format. It sets the configured row format on each of the tables Drupal creates.

Running mysqloptimize doesn't change it back. The table keeps its row format.

It would be super to implement it in the module!

I have no clue currently on how to do that and can't find the time to dig into it, unfortunately (haven't found the time in the last 3.5 years…).

Patches, directions, proof-of-concepts, etc. are more than welcome!

Since Drupal 7 is now unsupported, I'll close this issue.

Since Drupal 7 is now unsupported, I'll close this issue.

Since Drupal 7 is now unsupported I'll close this issue.

Since Drupal 7 is now unsupported I'll close this issue.

Since Drupal 7 is now unsupported I'll close this issue.

Since Drupal 7 is now unsupported I'll close this issue.

Since Drupal 7 is now unsupported I'll close this issue.

Since Drupal 7 is now unsupported I'll close this issue.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of the Snapengage module either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Collation Fixer either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 7 is now unsupported and there will be no more development on the Drupal 7 branch of Ultimate Cron either.

Thank you for taking the time and effort in reporting this issue, even though it never got resolved.

I'm closing this since Drupal 6 has been unsupported for many years.

Thank you for the patch, @narkoff.

I have committed it and released it as version 7.x-2.11 → .

Maybe a combination?

This patch declares the properties that are actually used in the class itself.

And then it declares AllowDynamicProperties for all the other properties to not emit warnings.

Yes, I think adding the properties are the way forward.

On the other hand, Drupal 7 is soon too be unsupported. So I think both approaches are valid now.

Would you mind creating a patch?

I'm not using Drupal 7 anymore myself, so I would just end up blindly adding what you suggest anyway :)

Probably, @narkoff.

Does this patch work?

A good patch makes a difference 🥰

Thank you for the patch!

It has been committed and released in the 7.x-2.10 → release.

Thank you for the patch!

It has been committed and released in the 7.x-2.10 → release.

The Nagios implementation was part of 7.x-1.x and hasn't been implemented in 7.x-2.x.

The 7.x-1.x branch is not supported anymore.

I'm pretty sure this is fixed / handled by the change in #2833129 → .

I couldn't make any sense out of the nightwatch failure.

I did a rebase on 11.x and now the tests are all green.

(Attempt at) Change Record added.

arnested → changed the visibility of the branch 10.1.x to hidden.

I have added an 11.x merge request for this. All merge request comments have been resolved.

I was the one citing disk space as a reasoning in the first place. I can elaborate a bit on why this was important for us.

We run a single server with currently 450 small, low traffic sites. The overhead of the database tables, even without any real content, was huge before we added row format compressed.

6 years ago, we started out with 401 sites. After doing site install of 300~ sites, we had filled up the 100 GiB disk. After shifting to row format compressed we had plenty of available disk space.

The change is small, it only affects the MySQL driver, and the change is inline with similar features for the MySQL driver, e.g. the "collate" option.

arnested → changed the visibility of the branch 10.1.x to active.

arnested → changed the visibility of the branch 10.1.x to hidden.

I fixed the comment addressed in the merge request.

arnested → changed the visibility of the branch 3359649-deprecated-function-explode to hidden.

OK, I got a test that triggers the deprecation notice.

The deprecation notice occurs when some other module/code has altered away the _format on, e.g., the user.pass.http route.

But now I'm unsure what the serialization module should actually do when coming across such a route. Should it still alter the route and add json|xml as _format, or should it refrain from adding an altered format back in?

My first thought was to not add it, but on a second thought, I think it should. If you really want the format gone, you should probably make sure your event subscriber runs after the serialization module's event subscriber.

Issue summary updated.

Fixed phpstan issue.

I'm reopening this and adding a suggested fix.

I'm running into this issue as well.

My use case is that I want to deny access to /user/password (we use an external login provider).

In a RouteSubscriber::alterRoutes() we do:

    if ($route = $collection->get('user.pass.http')) {
      $route->setRequirements([]);
      $route->setRequirement('_access', 'FALSE');
    }

We clear all existing requirements and then set access to FALSE because we want to be sure no other requirements interfere.

But then there is no format on the route (and none should be needed).

arnested → made their first commit to this issue’s fork.

as the function argument changed issue needs change record

@tstoeckler already added a change record: https://www.drupal.org/node/3182651 →

I was about o, but got distracted. Pushed now.

Reroll.

Oh. This only happens when I select the “Plugin reference” field type. If I select the “Filter” field type, it works.

What is the difference? I wasn't expecting to use a type named “Filter”. Reading the description made me try, though.

arnested → created an issue.

GH79382498HG

Nice. I was looking for exactly this today!

I have tested the code together with Drupal 10.3 and can confirm it works.

Since I wanted to have the benefit of this right away, I took the liberty and made it a small module: https://www.drupal.org/project/autowire_plugin_trait →

arnested → changed the visibility of the branch 3452916-get_class-is-deprecated to hidden.