- Issue created by @kostyashupenko
- ๐ฎ๐ณIndia AnjaliPrasannan
@kostyashupenko I have created a patch for the issue. The next step would be the front end changes.
- ๐ฎ๐ณIndia AnjaliPrasannan
Updated patch added. Please continue with the design change for drop down.
- Status changed to Needs review
over 1 year ago 8:09am 21 August 2023 - last update
over 1 year ago 30,056 pass - ๐ฎ๐ณIndia Harish1688 India
Hi,
As per comment #5, created a
(3381598-7.patch)
patch for the select box(#5 patch convert tabs into select box)
theming.
attached the screenshot for reference.Testing Steps:
1. Drupal setup 11.x and create several view modes as per issue summary.
2. Applied a patch (3381598-7.patch), check the select box theme on the path (admin/structure/media/manage/image/display
).Needs Review.
- Status changed to Needs work
over 1 year ago 1:16pm 21 August 2023 - ๐บ๐ธUnited States smustgrave
If we are going to update the twig templates we will have to update all them and provide a CR for contrib themes to update theirs.
- ๐ฎ๐ณIndia prashant.c Dharamshala
Prashant.c โ made their first commit to this issueโs fork.
- Merge request !5826Draft: Adding onchange event and selected attribute to the dropdown โ (Open) created by prashant.c
- ๐ฎ๐ณIndia prashant.c Dharamshala
- Select list options were not loading the respective pages, added onchange event to the select list.
- Added
selected
attribute based on the current active option - There are still some UI issues as well for the Select list like fonts etc.
Created MR from the patch along with additions from my end, Please review.
Thanks!
- ๐ช๐ธSpain ckrina Barcelona
Thanks for the proposed solutions, bit this needs to create a new design pattern instead of reusing existing ones. So the next step here is to come up with a better design.
- ๐บ๐ธUnited States devitate Orange County, CA
The Primary tabs works as a dropdown already, and also has some responsive aspect to when it drops.
Why not just remove the lines blocking the secondary tabs from the same behavior?
Then possibly:- Ass some style to make secondary more distinct.
- Make a label to explain what the is-active button represents.